diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2016-12-16 13:42:06 -0500 |
|---|---|---|
| committer | Andreas Blaesius <skate4life@gmx.de> | 2017-03-17 11:02:29 +0100 |
| commit | 1f19ffb5170347ac667f6cc3450b30fcd72b054c (patch) | |
| tree | 22c8c387ce5718e6c4661e0ab070048a49049dbb /drivers/scsi/sg.c | |
| parent | 22837db7f47b8147a31f06c4c064d4268798a8bc (diff) | |
| download | kernel_samsung_espresso10-1f19ffb5170347ac667f6cc3450b30fcd72b054c.zip kernel_samsung_espresso10-1f19ffb5170347ac667f6cc3450b30fcd72b054c.tar.gz kernel_samsung_espresso10-1f19ffb5170347ac667f6cc3450b30fcd72b054c.tar.bz2 | |
sg_write()/bsg_write() is not fit to be called under KERNEL_DS
Both damn things interpret userland pointers embedded into the payload;
worse, they are actually traversing those. Leaving aside the bad
API design, this is very much _not_ safe to call with KERNEL_DS.
Bail out early if that happens.
Change-Id: I9fe7a5855db598eaa515007603b7e327aee74305
Cc: stable@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'drivers/scsi/sg.c')
| -rw-r--r-- | drivers/scsi/sg.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index 4172f89..819c84b 100644 --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c @@ -543,6 +543,9 @@ sg_write(struct file *filp, const char __user *buf, size_t count, loff_t * ppos) sg_io_hdr_t *hp; unsigned char cmnd[MAX_COMMAND_SIZE]; + if (unlikely(segment_eq(get_fs(), KERNEL_DS))) + return -EINVAL; + if ((!(sfp = (Sg_fd *) filp->private_data)) || (!(sdp = sfp->parentdp))) return -ENXIO; SCSI_LOG_TIMEOUT(3, printk("sg_write: %s, count=%d\n", |