aboutsummaryrefslogtreecommitdiffstats
path: root/fs/f2fs
diff options
context:
space:
mode:
authorJaegeuk Kim <jaegeuk.kim@samsung.com>2014-04-01 17:38:26 +0900
committerAndreas Blaesius <skate4life@gmx.de>2016-06-05 21:21:24 +0200
commitc22d9045c2f43ccec993d452090b5aa5ab87827f (patch)
tree5699066cc50114ae9313cd8f1adf6f7b9e9214b4 /fs/f2fs
parentb9025edb4cf8408501f1c63f9415d9a9adb4c471 (diff)
downloadkernel_samsung_espresso10-c22d9045c2f43ccec993d452090b5aa5ab87827f.zip
kernel_samsung_espresso10-c22d9045c2f43ccec993d452090b5aa5ab87827f.tar.gz
kernel_samsung_espresso10-c22d9045c2f43ccec993d452090b5aa5ab87827f.tar.bz2
f2fs: return -EIO when node id is not matched
During the cleaing of node segments, F2FS can get errored node blocks due to data race between node page lock and its valid bitmap operations. In that case, it needs to return an error to skip such the obsolete block copy. Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Diffstat (limited to 'fs/f2fs')
-rw-r--r--fs/f2fs/node.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index fa41363..e22ce4c 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -958,7 +958,7 @@ repeat:
goto got_it;
lock_page(page);
- if (unlikely(!PageUptodate(page))) {
+ if (unlikely(!PageUptodate(page) || nid != nid_of_node(page))) {
f2fs_put_page(page, 1);
return ERR_PTR(-EIO);
}
@@ -967,7 +967,6 @@ repeat:
goto repeat;
}
got_it:
- f2fs_bug_on(nid != nid_of_node(page));
mark_page_accessed(page);
return page;
}