diff options
| author | Christoph Hellwig <hch@lst.de> | 2010-06-04 11:29:56 +0200 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2010-08-09 16:47:31 -0400 |
| commit | f4e420dc423148fba637af1ab618fa8896dfb2d6 (patch) | |
| tree | df0e81f5f4b8448dd6b3929e5537dcc46e7d7dde /fs/ufs/util.h | |
| parent | 282dc178849882289d30e58b54be6b2799b351aa (diff) | |
| download | kernel_samsung_espresso10-f4e420dc423148fba637af1ab618fa8896dfb2d6.zip kernel_samsung_espresso10-f4e420dc423148fba637af1ab618fa8896dfb2d6.tar.gz kernel_samsung_espresso10-f4e420dc423148fba637af1ab618fa8896dfb2d6.tar.bz2 | |
clean up write_begin usage for directories in pagecache
For filesystem that implement directories in pagecache we call
block_write_begin with an already allocated page for this code, while the
normal regular file write path uses the default block_write_begin behaviour.
Get rid of the __foofs_write_begin helper and opencode the normal write_begin
call in foofs_write_begin, while adding a new foofs_prepare_chunk helper for
the directory code. The added benefit is that foofs_prepare_chunk has
a much saner calling convention.
Note that the interruptible flag passed into block_write_begin is always
ignored if we already pass in a page (see next patch for details), and
we never were doing truncations of exessive blocks for this case either so we
can switch directly to block_write_begin_newtrunc.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/ufs/util.h')
| -rw-r--r-- | fs/ufs/util.h | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/fs/ufs/util.h b/fs/ufs/util.h index 23ceed8..0466036 100644 --- a/fs/ufs/util.h +++ b/fs/ufs/util.h @@ -257,9 +257,7 @@ ufs_set_inode_gid(struct super_block *sb, struct ufs_inode *inode, u32 value) extern dev_t ufs_get_inode_dev(struct super_block *, struct ufs_inode_info *); extern void ufs_set_inode_dev(struct super_block *, struct ufs_inode_info *, dev_t); -extern int __ufs_write_begin(struct file *file, struct address_space *mapping, - loff_t pos, unsigned len, unsigned flags, - struct page **pagep, void **fsdata); +extern int ufs_prepare_chunk(struct page *page, loff_t pos, unsigned len); /* * These functions manipulate ufs buffers |