diff options
author | Nick Piggin <npiggin@suse.de> | 2006-09-25 23:31:24 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-09-26 08:48:48 -0700 |
commit | db37648cd6ce9b828abd6d49aa3d269926ee7b7d (patch) | |
tree | a0155c7897f4706386d10c8718f98687bc357c82 /mm/page-writeback.c | |
parent | 28e4d965e6131ace1e813e93aebca89ac6b82dc1 (diff) | |
download | kernel_samsung_espresso10-db37648cd6ce9b828abd6d49aa3d269926ee7b7d.zip kernel_samsung_espresso10-db37648cd6ce9b828abd6d49aa3d269926ee7b7d.tar.gz kernel_samsung_espresso10-db37648cd6ce9b828abd6d49aa3d269926ee7b7d.tar.bz2 |
[PATCH] mm: non syncing lock_page()
lock_page needs the caller to have a reference on the page->mapping inode
due to sync_page, ergo set_page_dirty_lock is obviously buggy according to
its comments.
Solve it by introducing a new lock_page_nosync which does not do a sync_page.
akpm: unpleasant solution to an unpleasant problem. If it goes wrong it could
cause great slowdowns while the lock_page() caller waits for kblockd to
perform the unplug. And if a filesystem has special sync_page() requirements
(none presently do), permanent hangs are possible.
otoh, set_page_dirty_lock() is usually (always?) called against userspace
pages. They are always up-to-date, so there shouldn't be any pending read I/O
against these pages.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'mm/page-writeback.c')
-rw-r--r-- | mm/page-writeback.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/page-writeback.c b/mm/page-writeback.c index b9f4c6f..5557529 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -701,7 +701,7 @@ int set_page_dirty_lock(struct page *page) { int ret; - lock_page(page); + lock_page_nosync(page); ret = set_page_dirty(page); unlock_page(page); return ret; |