diff options
| author | Mark Grondona <mgrondona@llnl.gov> | 2013-09-11 14:24:31 -0700 |
|---|---|---|
| committer | Andreas Blaesius <skate4life@gmx.de> | 2016-10-12 23:24:47 +0200 |
| commit | b3413f4a6c00b725aff22049197e3e426ecc9444 (patch) | |
| tree | 546ca76eabc93844158e4140a25755ee66661020 /net/dcb | |
| parent | 2c4b220c90e7f03f3485bb015c996d126f7a97b5 (diff) | |
| download | kernel_samsung_espresso10-b3413f4a6c00b725aff22049197e3e426ecc9444.zip kernel_samsung_espresso10-b3413f4a6c00b725aff22049197e3e426ecc9444.tar.gz kernel_samsung_espresso10-b3413f4a6c00b725aff22049197e3e426ecc9444.tar.bz2 | |
__ptrace_may_access() should not deny sub-threads
commit 73af963f9f3036dffed55c3a2898598186db1045 upstream.
__ptrace_may_access() checks get_dumpable/ptrace_has_cap/etc if task !=
current, this can can lead to surprising results.
For example, a sub-thread can't readlink("/proc/self/exe") if the
executable is not readable. setup_new_exec()->would_dump() notices that
inode_permission(MAY_READ) fails and then it does
set_dumpable(suid_dumpable). After that get_dumpable() fails.
(It is not clear why proc_pid_readlink() checks get_dumpable(), perhaps we
could add PTRACE_MODE_NODUMPABLE)
Change __ptrace_may_access() to use same_thread_group() instead of "task
== current". Any security check is pointless when the tasks share the
same ->mm.
Change-Id: Ib6ca927a1eb0637df8030aabcb3129d5be343512
Signed-off-by: Mark Grondona <mgrondona@llnl.gov>
Signed-off-by: Ben Woodard <woodard@redhat.com>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/dcb')
0 files changed, 0 insertions, 0 deletions