diff options
| author | Dan Carpenter <error27@gmail.com> | 2010-03-15 07:28:00 -0500 |
|---|---|---|
| committer | Jason Wessel <jason.wessel@windriver.com> | 2011-03-25 16:37:30 -0500 |
| commit | adb4b83c12f9d966ea3478aa14c60511467c9916 (patch) | |
| tree | b9dd2efee119cc6f053ffa6fb50a3d336e5e3dfb | |
| parent | 521cb40b0c44418a4fd36dc633f575813d59a43d (diff) | |
| download | kernel_samsung_smdk4412-adb4b83c12f9d966ea3478aa14c60511467c9916.zip kernel_samsung_smdk4412-adb4b83c12f9d966ea3478aa14c60511467c9916.tar.gz kernel_samsung_smdk4412-adb4b83c12f9d966ea3478aa14c60511467c9916.tar.bz2 | |
kgdboc,kgdbts: strlen() doesn't count the terminator
This is an off by one because strlen() doesn't count the null
terminator. We strcpy() these strings into an array of size
MAX_CONFIG_LEN.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
| -rw-r--r-- | drivers/misc/kgdbts.c | 2 | ||||
| -rw-r--r-- | drivers/tty/serial/kgdboc.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/drivers/misc/kgdbts.c b/drivers/misc/kgdbts.c index 59c118c..27dc463 100644 --- a/drivers/misc/kgdbts.c +++ b/drivers/misc/kgdbts.c @@ -988,7 +988,7 @@ static void kgdbts_run_tests(void) static int kgdbts_option_setup(char *opt) { - if (strlen(opt) > MAX_CONFIG_LEN) { + if (strlen(opt) >= MAX_CONFIG_LEN) { printk(KERN_ERR "kgdbts: config string too long\n"); return -ENOSPC; } diff --git a/drivers/tty/serial/kgdboc.c b/drivers/tty/serial/kgdboc.c index 25a8bc5..87e7e6c 100644 --- a/drivers/tty/serial/kgdboc.c +++ b/drivers/tty/serial/kgdboc.c @@ -131,7 +131,7 @@ static void kgdboc_unregister_kbd(void) static int kgdboc_option_setup(char *opt) { - if (strlen(opt) > MAX_CONFIG_LEN) { + if (strlen(opt) >= MAX_CONFIG_LEN) { printk(KERN_ERR "kgdboc: config string too long\n"); return -ENOSPC; } |