aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMark Brown <broonie@opensource.wolfsonmicro.com>2010-11-09 12:00:11 +0000
committerMark Brown <broonie@opensource.wolfsonmicro.com>2010-11-10 15:40:06 +0000
commitc28a9926f28e8c7c52603db58754a78008768ca1 (patch)
treeed2f49458800eeefb41e18d553bb93b396d31d3e
parentb0fc7b840926654a3a6eaf0f41f3a4da33441d3d (diff)
downloadkernel_samsung_smdk4412-c28a9926f28e8c7c52603db58754a78008768ca1.zip
kernel_samsung_smdk4412-c28a9926f28e8c7c52603db58754a78008768ca1.tar.gz
kernel_samsung_smdk4412-c28a9926f28e8c7c52603db58754a78008768ca1.tar.bz2
ASoC: Remove broken WM8350 direction constants
The WM8350 driver was using some custom constants to interpret the direction of the MCLK signal which had the opposite values to those used as standard by the ASoC core, causing confusion in machine drivers such as the 1133-EV1 board. Reported-by: Tommy Zhu <Tommy.Zhu@wolfsonmicro.com> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
-rw-r--r--include/linux/mfd/wm8350/audio.h3
-rw-r--r--sound/soc/codecs/wm8350.c2
2 files changed, 1 insertions, 4 deletions
diff --git a/include/linux/mfd/wm8350/audio.h b/include/linux/mfd/wm8350/audio.h
index a95141e..bd581c6 100644
--- a/include/linux/mfd/wm8350/audio.h
+++ b/include/linux/mfd/wm8350/audio.h
@@ -522,9 +522,6 @@
#define WM8350_MCLK_SEL_PLL_32K 3
#define WM8350_MCLK_SEL_MCLK 5
-#define WM8350_MCLK_DIR_OUT 0
-#define WM8350_MCLK_DIR_IN 1
-
/* clock divider id's */
#define WM8350_ADC_CLKDIV 0
#define WM8350_DAC_CLKDIV 1
diff --git a/sound/soc/codecs/wm8350.c b/sound/soc/codecs/wm8350.c
index f4f1fba..4f3e919 100644
--- a/sound/soc/codecs/wm8350.c
+++ b/sound/soc/codecs/wm8350.c
@@ -831,7 +831,7 @@ static int wm8350_set_dai_sysclk(struct snd_soc_dai *codec_dai,
}
/* MCLK direction */
- if (dir == WM8350_MCLK_DIR_OUT)
+ if (dir == SND_SOC_CLOCK_OUT)
wm8350_set_bits(wm8350, WM8350_CLOCK_CONTROL_2,
WM8350_MCLK_DIR);
else