diff options
| author | Alan Ott <alan@signal11.us> | 2010-09-22 13:19:42 +0200 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2010-09-22 13:19:42 +0200 |
| commit | fe2c91ee245bd81230f1d67645237a684b90be2b (patch) | |
| tree | 75c9890f5b1480e9680d5fa2d844cc9202ed4ac9 /drivers/hid | |
| parent | 9c03f1622af051004416dd3e24d8a0fa31e34178 (diff) | |
| download | kernel_samsung_smdk4412-fe2c91ee245bd81230f1d67645237a684b90be2b.zip kernel_samsung_smdk4412-fe2c91ee245bd81230f1d67645237a684b90be2b.tar.gz kernel_samsung_smdk4412-fe2c91ee245bd81230f1d67645237a684b90be2b.tar.bz2 | |
HID: don't Send Feature Reports on Interrupt Endpoint
Feature reports should only be sent on the control endpoint.
The USB HID standard is unclear and confusing on this issue. It seems to
suggest that Feature reports can be sent on a HID device's Interrupt OUT
endpoint. This cannot be the case because the report type is not encoded in
transfers sent out the Interrput OUT endpoint. If Feature reports were sent on
the Interrupt OUT endpint, they would be indistinguishable from Output reports
in the case where Report IDs were not used.
Further, Windows and Mac OS X do not send Feature reports out the interrupt OUT
Endpoint. They will only go out the Control Endpoint.
In addition, many devices simply do not hande Feature reports sent out the
Interrupt OUT endpoint.
Reported-by: simon@mungewell.org
Signed-off-by: Alan Ott <alan@signal11.us>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid')
| -rw-r--r-- | drivers/hid/usbhid/hid-core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c index 599041a..39913f5 100644 --- a/drivers/hid/usbhid/hid-core.c +++ b/drivers/hid/usbhid/hid-core.c @@ -807,7 +807,7 @@ static int usbhid_output_raw_report(struct hid_device *hid, __u8 *buf, size_t co struct usb_host_interface *interface = intf->cur_altsetting; int ret; - if (usbhid->urbout) { + if (usbhid->urbout && report_type != HID_FEATURE_REPORT) { int actual_length; int skipped_report_id = 0; if (buf[0] == 0x0) { |