diff options
| author | Lachlan McIlroy <lachlan@sgi.com> | 2008-08-13 16:51:57 +1000 |
|---|---|---|
| committer | Lachlan McIlroy <lachlan@redback.melbourne.sgi.com> | 2008-08-13 16:51:57 +1000 |
| commit | 5695ef46ef02ba1c6658daa46e6879a2d4f52f5f (patch) | |
| tree | 885687ac9cdbba4717f01eef26195fd4eef2ee90 /fs/xfs/xfs_log.c | |
| parent | d62c251fe4a06144255291cffd68cbadf3bf002f (diff) | |
| download | kernel_samsung_smdk4412-5695ef46ef02ba1c6658daa46e6879a2d4f52f5f.zip kernel_samsung_smdk4412-5695ef46ef02ba1c6658daa46e6879a2d4f52f5f.tar.gz kernel_samsung_smdk4412-5695ef46ef02ba1c6658daa46e6879a2d4f52f5f.tar.bz2 | |
[XFS] Use KM_NOFS for debug trace buffers
Use KM_NOFS to prevent recursion back into the filesystem which can cause
deadlocks.
In the case of xfs_iread() we hold the lock on the inode cluster buffer
while allocating memory for the trace buffers. If we recurse back into XFS
to flush data that may require a transaction to allocate extents which
needs log space. This can deadlock with the xfsaild thread which can't
push the tail of the log because it is trying to get the inode cluster
buffer lock.
SGI-PV: 981498
SGI-Modid: xfs-linux-melb:xfs-kern:31838a
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
Signed-off-by: David Chinner <david@fromorbit.com>
Diffstat (limited to 'fs/xfs/xfs_log.c')
| -rw-r--r-- | fs/xfs/xfs_log.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c index 9c23864..1f6f780 100644 --- a/fs/xfs/xfs_log.c +++ b/fs/xfs/xfs_log.c @@ -160,7 +160,7 @@ void xlog_trace_iclog(xlog_in_core_t *iclog, uint state) { if (!iclog->ic_trace) - iclog->ic_trace = ktrace_alloc(256, KM_SLEEP); + iclog->ic_trace = ktrace_alloc(256, KM_NOFS); ktrace_enter(iclog->ic_trace, (void *)((unsigned long)state), (void *)((unsigned long)current_pid()), |