diff options
| author | Simon Horman <horms@verge.net.au> | 2010-09-21 21:17:30 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-09-22 13:13:32 -0700 |
| commit | 7874896a26624214bd7c05eeba7c8ab01548b1b5 (patch) | |
| tree | 15e62e0eb2c2a1ac911ae6a6ccb5806d0aa0c2a9 /net | |
| parent | d485d500cf6b13a33bc7a6c09091deea7ea603ca (diff) | |
| download | kernel_samsung_smdk4412-7874896a26624214bd7c05eeba7c8ab01548b1b5.zip kernel_samsung_smdk4412-7874896a26624214bd7c05eeba7c8ab01548b1b5.tar.gz kernel_samsung_smdk4412-7874896a26624214bd7c05eeba7c8ab01548b1b5.tar.bz2 | |
netfilter: nf_ct_sip: default to NF_ACCEPT in sip_help_tcp()
I initially noticed this because of the compiler warning below, but it
does seem to be a valid concern in the case where ct_sip_get_header()
returns 0 in the first iteration of the while loop.
net/netfilter/nf_conntrack_sip.c: In function 'sip_help_tcp':
net/netfilter/nf_conntrack_sip.c:1379: warning: 'ret' may be used uninitialized in this function
Signed-off-by: Simon Horman <horms@verge.net.au>
[Patrick: changed NF_DROP to NF_ACCEPT]
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/netfilter/nf_conntrack_sip.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/nf_conntrack_sip.c b/net/netfilter/nf_conntrack_sip.c index 53d8922..f64de95 100644 --- a/net/netfilter/nf_conntrack_sip.c +++ b/net/netfilter/nf_conntrack_sip.c @@ -1376,7 +1376,7 @@ static int sip_help_tcp(struct sk_buff *skb, unsigned int protoff, unsigned int msglen, origlen; const char *dptr, *end; s16 diff, tdiff = 0; - int ret; + int ret = NF_ACCEPT; typeof(nf_nat_sip_seq_adjust_hook) nf_nat_sip_seq_adjust; if (ctinfo != IP_CT_ESTABLISHED && |