diff options
| author | Vikram Pandita <vikram.pandita@ti.com> | 2011-10-28 11:44:42 -0700 |
|---|---|---|
| committer | Benoit Goby <benoit@android.com> | 2011-10-28 16:28:21 -0700 |
| commit | 57c54e5dd1e5d5eb778639e2383196ec1865cd3e (patch) | |
| tree | f0bc9db0bbeb7cf277819912058cf5546fe7c3f7 | |
| parent | dd76ec7cf2a80d09717045fd7e735a036fbaf90a (diff) | |
| download | kernel_samsung_tuna-57c54e5dd1e5d5eb778639e2383196ec1865cd3e.zip kernel_samsung_tuna-57c54e5dd1e5d5eb778639e2383196ec1865cd3e.tar.gz kernel_samsung_tuna-57c54e5dd1e5d5eb778639e2383196ec1865cd3e.tar.bz2 | |
mfd: omap: fix hostconfig incr_align bit
Its found on simulation results of EHCI IP, that there are
worse OCP accesses generated when ENA_INCR_ALIGN = 1
Looks the bit is not exactly doing what it was designed for.
Simulation results for ENA_INCR_ALIGN == 0 show much lesser
OCP L3 interconnect requests being generated as opposed to
Simulation results for ENA_INCR_ALIGN == 1
So switch ENA_INCR_ALIGN back to 0
Change-Id: Ic832d65a7b3acf2df1a696bf3aeee5d26d706134
Reported-by: John Grossman <johngro@google.com>
Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
| -rw-r--r-- | drivers/mfd/omap-usb-host.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c index a63a4ce..130d950 100644 --- a/drivers/mfd/omap-usb-host.c +++ b/drivers/mfd/omap-usb-host.c @@ -761,8 +761,10 @@ static void omap_usbhs_init(struct device *dev) /* setup ULPI bypass and burst configurations */ reg |= (OMAP_UHH_HOSTCONFIG_INCR4_BURST_EN | OMAP_UHH_HOSTCONFIG_INCR8_BURST_EN - | OMAP_UHH_HOSTCONFIG_INCR16_BURST_EN - | OMAP_UHH_HOSTCONFIG_INCRX_ALIGN_EN); + | OMAP_UHH_HOSTCONFIG_INCR16_BURST_EN); + + /* Keep ENA_INCR_ALIGN = 0: Known to cause OCP delays */ + reg &= ~OMAP_UHH_HOSTCONFIG_INCRX_ALIGN_EN; if (is_omap_usbhs_rev1(omap)) { if (pdata->port_mode[0] == OMAP_USBHS_PORT_MODE_UNUSED) |