diff options
| author | Henrik Rydberg <rydberg@euromail.se> | 2012-01-26 06:08:41 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-10-05 07:00:40 -0700 |
| commit | 96ec909de79e2cc422126fdeb427fe8d0ffb4b95 (patch) | |
| tree | fad446e50d7ffeac7a601ed55093307ce0279119 | |
| parent | 94c7268325e30ecb4767b9c080e8cec9c92d6689 (diff) | |
| download | kernel_samsung_tuna-96ec909de79e2cc422126fdeb427fe8d0ffb4b95.zip kernel_samsung_tuna-96ec909de79e2cc422126fdeb427fe8d0ffb4b95.tar.gz kernel_samsung_tuna-96ec909de79e2cc422126fdeb427fe8d0ffb4b95.tar.bz2 | |
hwmon: (applesmc) Silence uninitialized warnings
commit 0fc86eca1b338d06ec500b34ef7def79c32b602b upstream.
Some error paths do not set a result, leading to the (false)
assumption that the value may be used uninitialized. Set results for
those paths as well.
Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/hwmon/applesmc.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/hwmon/applesmc.c b/drivers/hwmon/applesmc.c index 6218d08..30cac58 100644 --- a/drivers/hwmon/applesmc.c +++ b/drivers/hwmon/applesmc.c @@ -344,8 +344,10 @@ static int applesmc_get_lower_bound(unsigned int *lo, const char *key) while (begin != end) { int middle = begin + (end - begin) / 2; entry = applesmc_get_entry_by_index(middle); - if (IS_ERR(entry)) + if (IS_ERR(entry)) { + *lo = 0; return PTR_ERR(entry); + } if (strcmp(entry->key, key) < 0) begin = middle + 1; else @@ -364,8 +366,10 @@ static int applesmc_get_upper_bound(unsigned int *hi, const char *key) while (begin != end) { int middle = begin + (end - begin) / 2; entry = applesmc_get_entry_by_index(middle); - if (IS_ERR(entry)) + if (IS_ERR(entry)) { + *hi = smcreg.key_count; return PTR_ERR(entry); + } if (strcmp(key, entry->key) < 0) end = middle; else |