diff options
| author | Santosh Shilimkar <santosh.shilimkar@ti.com> | 2011-06-27 17:13:16 -0700 |
|---|---|---|
| committer | Nishanth Menon <nm@ti.com> | 2011-06-29 13:30:54 -0700 |
| commit | d60565948468b9ed9ea2eddbbfff8381225e526b (patch) | |
| tree | b9da66b95920d5688dca2ddcb67a0c0f4c548600 /arch/arm | |
| parent | 83b7522a2f70bc624b637f595912a470154a1d6d (diff) | |
| download | kernel_samsung_tuna-d60565948468b9ed9ea2eddbbfff8381225e526b.zip kernel_samsung_tuna-d60565948468b9ed9ea2eddbbfff8381225e526b.tar.gz kernel_samsung_tuna-d60565948468b9ed9ea2eddbbfff8381225e526b.tar.bz2 | |
OMAP4: clock: Keep GPMC clocks always enabled and hardware managed.
On OMAP4, CPU accesses on unmapped addresses are redirected to GPMC by
L3 interconnect. Because of CPU speculative nature, such accesses are possible
which can lead to indirect access to GPMC and if it.s clock is not running,
it can result in hang/abort on the platform.
Above makes access to GPMC unpredictable during the execution, so it's
module mode needs to be kept under hardware control instead of software control.
Since the auto gating is supported for GPMC, there is't a power impact because
of this change.
The issue was un-covered with security middleware running along with HLOS.
In this case GPMC had a valid MMU descriptor on secure side where as HLOS
didn't map the GMPC because it isn't being used.
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Kevin Hilman <khilman@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>
Cc: Benoit Cousson <b-cousson@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
Diffstat (limited to 'arch/arm')
| -rw-r--r-- | arch/arm/mach-omap2/clock44xx_data.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c index d332e7b..7478096 100644 --- a/arch/arm/mach-omap2/clock44xx_data.c +++ b/arch/arm/mach-omap2/clock44xx_data.c @@ -1734,6 +1734,7 @@ static struct clk gpmc_ick = { .enable_reg = OMAP4430_CM_L3_2_GPMC_CLKCTRL, .enable_bit = OMAP4430_MODULEMODE_HWCTRL, .clkdm_name = "l3_2_clkdm", + .flags = ENABLE_ON_INIT, .parent = &l3_div_ck, .recalc = &followparent_recalc, }; |