diff options
| author | H. Peter Anvin <hpa@zytor.com> | 2007-10-25 16:09:38 -0700 |
|---|---|---|
| committer | H. Peter Anvin <hpa@zytor.com> | 2007-10-25 20:20:06 -0700 |
| commit | e6e1ace9904b72478f0c5a5aa7bd174cb6f62561 (patch) | |
| tree | 8858fe4c1d37e4e9278020bf8fba369dfdddd2a7 /arch/x86/boot/video-bios.c | |
| parent | 6b6815c6d5d1dc209701d1661a7a0e09a295db2f (diff) | |
| download | kernel_samsung_tuna-e6e1ace9904b72478f0c5a5aa7bd174cb6f62561.zip kernel_samsung_tuna-e6e1ace9904b72478f0c5a5aa7bd174cb6f62561.tar.gz kernel_samsung_tuna-e6e1ace9904b72478f0c5a5aa7bd174cb6f62561.tar.bz2 | |
x86 setup: sizeof() is unsigned, unbreak comparisons
We use signed values for limit checking since the values can go
negative under certain circumstances. However, sizeof() is unsigned
and forces the comparison to be unsigned, so move the comparison into
the heap_free() macros so we can ensure it is a signed comparison.
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Diffstat (limited to 'arch/x86/boot/video-bios.c')
| -rw-r--r-- | arch/x86/boot/video-bios.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/boot/video-bios.c b/arch/x86/boot/video-bios.c index 68e65d9..ed0672a 100644 --- a/arch/x86/boot/video-bios.c +++ b/arch/x86/boot/video-bios.c @@ -79,7 +79,7 @@ static int bios_probe(void) video_bios.modes = GET_HEAP(struct mode_info, 0); for (mode = 0x14; mode <= 0x7f; mode++) { - if (heap_free() < sizeof(struct mode_info)) + if (!heap_free(sizeof(struct mode_info))) break; if (mode_defined(VIDEO_FIRST_BIOS+mode)) |