diff options
author | Ming Lei <tom.leiming@gmail.com> | 2009-01-21 23:27:47 +0800 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-03-24 16:38:24 -0700 |
commit | 49b420a13ff95b449947181190b08367348e3e1b (patch) | |
tree | 5feec1d1eac071e46c9aacec4255d891fa4f7ed2 /drivers/base/base.h | |
parent | 4a67a1bc0b3a0db017b560cee27370d141c58e25 (diff) | |
download | kernel_samsung_tuna-49b420a13ff95b449947181190b08367348e3e1b.zip kernel_samsung_tuna-49b420a13ff95b449947181190b08367348e3e1b.tar.gz kernel_samsung_tuna-49b420a13ff95b449947181190b08367348e3e1b.tar.bz2 |
driver core: check bus->match without holding device lock
This patch moves bus->match out from driver_probe_device and
does not hold device lock to check the match between a device
and a driver.
The idea has been verified by the commit 6cd495860901,
which leads to a faster boot. But the commit 6cd495860901 has
the following drawbacks: 1),only does the quick check in
the path of __driver_attach->driver_probe_device, not in other
paths; 2),for a matched device and driver, check the same match
twice. It is a waste of cpu ,especially for some drivers with long
device id table (eg. usb-storage driver).
This patch adds a helper of driver_match_device to check the match
in all paths, and testes the match only once.
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/base/base.h')
-rw-r--r-- | drivers/base/base.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/base/base.h b/drivers/base/base.h index 9f50f1b..ca2b037 100644 --- a/drivers/base/base.h +++ b/drivers/base/base.h @@ -86,6 +86,11 @@ extern void bus_remove_driver(struct device_driver *drv); extern void driver_detach(struct device_driver *drv); extern int driver_probe_device(struct device_driver *drv, struct device *dev); +static inline int driver_match_device(struct device_driver *drv, + struct device *dev) +{ + return drv->bus->match && drv->bus->match(dev, drv); +} extern void sysdev_shutdown(void); |