diff options
| author | Tejun Heo <tj@kernel.org> | 2011-12-14 00:33:38 +0100 |
|---|---|---|
| committer | Ziyan <jaraidaniel@gmail.com> | 2016-01-08 10:36:52 +0100 |
| commit | 2c042b3240aa259875629719383f6ec1aff3062c (patch) | |
| tree | b4aae97bbdcd7c0ac012c512c29599807143d2f6 /drivers/scsi | |
| parent | 7f4a4edb6dcace37887d6ec4fd20334190dd319b (diff) | |
| download | kernel_samsung_tuna-2c042b3240aa259875629719383f6ec1aff3062c.zip kernel_samsung_tuna-2c042b3240aa259875629719383f6ec1aff3062c.tar.gz kernel_samsung_tuna-2c042b3240aa259875629719383f6ec1aff3062c.tar.bz2 | |
block: misc updates to blk_get_queue()
* blk_get_queue() is peculiar in that it returns 0 on success and 1 on
failure instead of 0 / -errno or boolean. Update it such that it
returns %true on success and %false on failure.
* Make sure the caller checks for the return value.
* Separate out __blk_get_queue() which doesn't check whether @q is
dead and put it in blk.h. This will be used later.
This patch doesn't introduce any functional changes.
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/scsi')
| -rw-r--r-- | drivers/scsi/scsi_scan.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index c6c80c9..632f6fc 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -297,7 +297,7 @@ static struct scsi_device *scsi_alloc_sdev(struct scsi_target *starget, kfree(sdev); goto out; } - blk_get_queue(sdev->request_queue); + WARN_ON_ONCE(!blk_get_queue(sdev->request_queue)); sdev->request_queue->queuedata = sdev; scsi_adjust_queue_depth(sdev, 0, sdev->host->cmd_per_lun); |