diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2010-10-14 10:57:40 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-10-14 10:57:40 -0700 |
commit | 0eead9ab41da33644ae2c97c57ad03da636a0422 (patch) | |
tree | 757516bc7caa70a10101264edc3eac7d44c11ce8 /fs/binfmt_aout.c | |
parent | 53eeb64e808971207350386121f4bab12fa2f45f (diff) | |
download | kernel_samsung_tuna-0eead9ab41da33644ae2c97c57ad03da636a0422.zip kernel_samsung_tuna-0eead9ab41da33644ae2c97c57ad03da636a0422.tar.gz kernel_samsung_tuna-0eead9ab41da33644ae2c97c57ad03da636a0422.tar.bz2 |
Don't dump task struct in a.out core-dumps
akiphie points out that a.out core-dumps have that odd task struct
dumping that was never used and was never really a good idea (it goes
back into the mists of history, probably the original core-dumping
code). Just remove it.
Also do the access_ok() check on dump_write(). It probably doesn't
matter (since normal filesystems all seem to do it anyway), but he
points out that it's normally done by the VFS layer, so ...
[ I suspect that we should possibly do "vfs_write()" instead of
calling ->write directly. That also does the whole fsnotify and write
statistics thing, which may or may not be a good idea. ]
And just to be anal, do this all for the x86-64 32-bit a.out emulation
code too, even though it's not enabled (and won't currently even
compile)
Reported-by: akiphie <akiphie@lavabit.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/binfmt_aout.c')
-rw-r--r-- | fs/binfmt_aout.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/fs/binfmt_aout.c b/fs/binfmt_aout.c index f96eff0..a6395bd 100644 --- a/fs/binfmt_aout.c +++ b/fs/binfmt_aout.c @@ -134,10 +134,6 @@ static int aout_core_dump(struct coredump_params *cprm) if (!dump_write(file, dump_start, dump_size)) goto end_coredump; } -/* Finally dump the task struct. Not be used by gdb, but could be useful */ - set_fs(KERNEL_DS); - if (!dump_write(file, current, sizeof(*current))) - goto end_coredump; end_coredump: set_fs(fs); return has_dumped; |