diff options
| author | Julia Lawall <julia@diku.dk> | 2009-07-27 13:57:00 -0400 |
|---|---|---|
| committer | Chris Mason <chris.mason@oracle.com> | 2009-07-27 13:57:00 -0400 |
| commit | 631c07c8d12bcc6ce4a0fbfbd64ea843d78e2b10 (patch) | |
| tree | 67c1564674da446c0472d8265f67843ff6cbe891 /fs/btrfs | |
| parent | 9779b72f0584fd53e0de53f62f205bf0dc0db553 (diff) | |
| download | kernel_samsung_tuna-631c07c8d12bcc6ce4a0fbfbd64ea843d78e2b10.zip kernel_samsung_tuna-631c07c8d12bcc6ce4a0fbfbd64ea843d78e2b10.tar.gz kernel_samsung_tuna-631c07c8d12bcc6ce4a0fbfbd64ea843d78e2b10.tar.bz2 | |
Btrfs: Correct redundant test in add_inode_ref
dir has already been tested. It seems that this test should be on the
recently returned value inode.
A simplified version of the semantic match that finds this problem is as
follows: (http://www.emn.fr/x-info/coccinelle/)
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Chris Mason <chris.mason@oracle.com>
Diffstat (limited to 'fs/btrfs')
| -rw-r--r-- | fs/btrfs/tree-log.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c index 1956068..11d0787 100644 --- a/fs/btrfs/tree-log.c +++ b/fs/btrfs/tree-log.c @@ -797,7 +797,7 @@ static noinline int add_inode_ref(struct btrfs_trans_handle *trans, return -ENOENT; inode = read_one_inode(root, key->objectid); - BUG_ON(!dir); + BUG_ON(!inode); ref_ptr = btrfs_item_ptr_offset(eb, slot); ref_end = ref_ptr + btrfs_item_size_nr(eb, slot); |