diff options
author | Dave Chinner <dchinner@redhat.com> | 2012-03-07 04:50:25 +0000 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-04-02 09:27:13 -0700 |
commit | c5ee1ac24b6f878e63fd208984b3cfe3ccf7b9a8 (patch) | |
tree | 9674195b9f8c69f286e6ff09a67305f9c6e8ebdd /fs/gfs2/Makefile | |
parent | 6e8768d198a2ea5f31dbd2fe679a62c605fcdbbd (diff) | |
download | kernel_samsung_tuna-c5ee1ac24b6f878e63fd208984b3cfe3ccf7b9a8.zip kernel_samsung_tuna-c5ee1ac24b6f878e63fd208984b3cfe3ccf7b9a8.tar.gz kernel_samsung_tuna-c5ee1ac24b6f878e63fd208984b3cfe3ccf7b9a8.tar.bz2 |
xfs: fix inode lookup race
commit f30d500f809eca67a21704347ab14bb35877b5ee upstream.
When we get concurrent lookups of the same inode that is not in the
per-AG inode cache, there is a race condition that triggers warnings
in unlock_new_inode() indicating that we are initialising an inode
that isn't in a the correct state for a new inode.
When we do an inode lookup via a file handle or a bulkstat, we don't
serialise lookups at a higher level through the dentry cache (i.e.
pathless lookup), and so we can get concurrent lookups of the same
inode.
The race condition is between the insertion of the inode into the
cache in the case of a cache miss and a concurrently lookup:
Thread 1 Thread 2
xfs_iget()
xfs_iget_cache_miss()
xfs_iread()
lock radix tree
radix_tree_insert()
rcu_read_lock
radix_tree_lookup
lock inode flags
XFS_INEW not set
igrab()
unlock inode flags
rcu_read_unlock
use uninitialised inode
.....
lock inode flags
set XFS_INEW
unlock inode flags
unlock radix tree
xfs_setup_inode()
inode flags = I_NEW
unlock_new_inode()
WARNING as inode flags != I_NEW
This can lead to inode corruption, inode list corruption, etc, and
is generally a bad thing to occur.
Fix this by setting XFS_INEW before inserting the inode into the
radix tree. This will ensure any concurrent lookup will find the new
inode with XFS_INEW set and that forces the lookup to wait until the
XFS_INEW flag is removed before allowing the lookup to succeed.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/gfs2/Makefile')
0 files changed, 0 insertions, 0 deletions