aboutsummaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorJaegeuk Kim <jaegeuk.kim@samsung.com>2014-04-01 17:38:26 +0900
committerZiyan <jaraidaniel@gmail.com>2015-05-02 14:36:39 +0200
commitd302e989359f18ab1d4f34a333547413d569550d (patch)
tree48d6aee92e61c5030ffd31d8ad008ab40b32928e /fs
parent94209feb0679736f1c4a93af7b5442c036c7439e (diff)
downloadkernel_samsung_tuna-d302e989359f18ab1d4f34a333547413d569550d.zip
kernel_samsung_tuna-d302e989359f18ab1d4f34a333547413d569550d.tar.gz
kernel_samsung_tuna-d302e989359f18ab1d4f34a333547413d569550d.tar.bz2
f2fs: return -EIO when node id is not matched
During the cleaing of node segments, F2FS can get errored node blocks due to data race between node page lock and its valid bitmap operations. In that case, it needs to return an error to skip such the obsolete block copy. Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/f2fs/node.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index fa41363..e22ce4c 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -958,7 +958,7 @@ repeat:
goto got_it;
lock_page(page);
- if (unlikely(!PageUptodate(page))) {
+ if (unlikely(!PageUptodate(page) || nid != nid_of_node(page))) {
f2fs_put_page(page, 1);
return ERR_PTR(-EIO);
}
@@ -967,7 +967,6 @@ repeat:
goto repeat;
}
got_it:
- f2fs_bug_on(nid != nid_of_node(page));
mark_page_accessed(page);
return page;
}