diff options
| author | Marc Zyngier <maz@misterjones.org> | 2010-04-27 13:13:07 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-04-27 16:26:03 -0700 |
| commit | a2cb9aeb3c9b2475955cec328487484034f414e4 (patch) | |
| tree | 94ca8e8f602150cff3e6f98173c9377db165854c /lib/irq_regs.c | |
| parent | 3835541dd481091c4dbf5ef83c08aed12e50fd61 (diff) | |
| download | kernel_samsung_tuna-a2cb9aeb3c9b2475955cec328487484034f414e4.zip kernel_samsung_tuna-a2cb9aeb3c9b2475955cec328487484034f414e4.tar.gz kernel_samsung_tuna-a2cb9aeb3c9b2475955cec328487484034f414e4.tar.bz2 | |
gpio: fix pca953x set_type 'scheduling while atomic' bug
Bill Gatliff reported the following bug when using the irq_chip facility
of the pca953x driver on a PPC platform:
BUG: scheduling while atomic: insmod/1530/0x00000002
He traced it back to an i2c transaction in pca953x_irq_set_type(), which
can be called with interrupt disabled (from __setup_irq()). As the i2c
controller can sleep while sending a message, this qualifies as a bad
idea.
This patch moves the i2c transaction to pca953x_irq_bus_sync_unlock(),
where it is actually safe to send an i2c message.
[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Marc Zyngier <maz@misterjones.org>
Reported-by: Bill Gatliff <bgat@billgatliff.com>
Cc: Eric Miao <eric.y.miao@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib/irq_regs.c')
0 files changed, 0 insertions, 0 deletions