diff options
| author | Patrick McHardy <kaber@trash.net> | 2007-04-16 17:00:53 -0700 |
|---|---|---|
| committer | David S. Miller <davem@sunset.davemloft.net> | 2007-04-25 22:29:05 -0700 |
| commit | 6313c1e0992feaee56bc09b85042b3186041fa3c (patch) | |
| tree | f75cda674d8f2b62bcdb09e59f8bc7010003a91f /net/decnet | |
| parent | 1c2d670f3660e9103fdcdca702f6dbf8ea7d6afb (diff) | |
| download | kernel_samsung_tuna-6313c1e0992feaee56bc09b85042b3186041fa3c.zip kernel_samsung_tuna-6313c1e0992feaee56bc09b85042b3186041fa3c.tar.gz kernel_samsung_tuna-6313c1e0992feaee56bc09b85042b3186041fa3c.tar.bz2 | |
[RTNETLINK]: Remove unnecessary locking in dump callbacks
Since we're now holding the rtnl during the entire dump operation, we can
remove additional locking for rtnl protected data. This patch does that
for all simple cases (dev_base_lock for dev_base walking, RCU protection
for FIB rule dumping).
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/decnet')
| -rw-r--r-- | net/decnet/dn_dev.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/net/decnet/dn_dev.c b/net/decnet/dn_dev.c index 61be2ca..5c2a995 100644 --- a/net/decnet/dn_dev.c +++ b/net/decnet/dn_dev.c @@ -799,7 +799,6 @@ static int dn_nl_dump_ifaddr(struct sk_buff *skb, struct netlink_callback *cb) skip_ndevs = cb->args[0]; skip_naddr = cb->args[1]; - read_lock(&dev_base_lock); for (dev = dev_base, idx = 0; dev; dev = dev->next, idx++) { if (idx < skip_ndevs) continue; @@ -824,8 +823,6 @@ static int dn_nl_dump_ifaddr(struct sk_buff *skb, struct netlink_callback *cb) } } done: - read_unlock(&dev_base_lock); - cb->args[0] = idx; cb->args[1] = dn_idx; |