diff options
| author | Mark Grondona <mgrondona@llnl.gov> | 2013-09-11 14:24:31 -0700 |
|---|---|---|
| committer | Ziyan <jaraidaniel@gmail.com> | 2016-10-29 01:34:19 +0200 |
| commit | cbf8bf03ed041a2be4c03859c70899cb7cbadf36 (patch) | |
| tree | c3dae83d2abde4830467155bc9f9f3fe194d8254 /net/ipv4 | |
| parent | f888b692828a208aa487fd74ed698d3c4487285c (diff) | |
| download | kernel_samsung_tuna-cbf8bf03ed041a2be4c03859c70899cb7cbadf36.zip kernel_samsung_tuna-cbf8bf03ed041a2be4c03859c70899cb7cbadf36.tar.gz kernel_samsung_tuna-cbf8bf03ed041a2be4c03859c70899cb7cbadf36.tar.bz2 | |
__ptrace_may_access() should not deny sub-threads
commit 73af963f9f3036dffed55c3a2898598186db1045 upstream.
__ptrace_may_access() checks get_dumpable/ptrace_has_cap/etc if task !=
current, this can can lead to surprising results.
For example, a sub-thread can't readlink("/proc/self/exe") if the
executable is not readable. setup_new_exec()->would_dump() notices that
inode_permission(MAY_READ) fails and then it does
set_dumpable(suid_dumpable). After that get_dumpable() fails.
(It is not clear why proc_pid_readlink() checks get_dumpable(), perhaps we
could add PTRACE_MODE_NODUMPABLE)
Change __ptrace_may_access() to use same_thread_group() instead of "task
== current". Any security check is pointless when the tasks share the
same ->mm.
Change-Id: Ib6ca927a1eb0637df8030aabcb3129d5be343512
Signed-off-by: Mark Grondona <mgrondona@llnl.gov>
Signed-off-by: Ben Woodard <woodard@redhat.com>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/ipv4')
0 files changed, 0 insertions, 0 deletions