aboutsummaryrefslogtreecommitdiffstats
path: root/sound
diff options
context:
space:
mode:
authorKangjie Lu <kangjielu@gmail.com>2016-05-03 16:44:32 -0400
committerZiyan <jaraidaniel@gmail.com>2016-10-29 01:34:13 +0200
commit6dd8bc733e896bdeee66992737292cec28ef2339 (patch)
tree0d62c9d25dc84aaf27f26f9c063812b8196006f5 /sound
parent7e256b4cf4b87a702cb8456f539071285f375da9 (diff)
downloadkernel_samsung_tuna-6dd8bc733e896bdeee66992737292cec28ef2339.zip
kernel_samsung_tuna-6dd8bc733e896bdeee66992737292cec28ef2339.tar.gz
kernel_samsung_tuna-6dd8bc733e896bdeee66992737292cec28ef2339.tar.bz2
ALSA: timer: Fix leak in events via snd_timer_user_tinterrupt
The stack object “r1” has a total size of 32 bytes. Its field “event” and “val” both contain 4 bytes padding. These 8 bytes padding bytes are sent to user without being initialized. Change-Id: Ie3dcdee7da8ad292712814e8402c571a717ab8d1 Signed-off-by: Kangjie Lu <kjlu@gatech.edu> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound')
-rw-r--r--sound/core/timer.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/core/timer.c b/sound/core/timer.c
index c0a11d5..22c43b3 100644
--- a/sound/core/timer.c
+++ b/sound/core/timer.c
@@ -1215,6 +1215,7 @@ static void snd_timer_user_tinterrupt(struct snd_timer_instance *timeri,
}
if ((tu->filter & (1 << SNDRV_TIMER_EVENT_RESOLUTION)) &&
tu->last_resolution != resolution) {
+ memset(&r1, 0, sizeof(r1));
r1.event = SNDRV_TIMER_EVENT_RESOLUTION;
r1.tstamp = tstamp;
r1.val = resolution;