summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMathieu Chartier <mathieuc@google.com>2014-11-25 23:32:10 +0000
committerAndroid (Google) Code Review <android-gerrit@google.com>2014-11-25 23:32:10 +0000
commit9250fd718bd449cab13681cbc2b31bf65569d31f (patch)
tree44ffa94dd2b75c1653f8e0a2d8a8aefc8b44d513
parentaa0045f52b0c780794dcf85acffc66e188b3681c (diff)
parentb9a5206b91a656c091e7055ff70e4eed2c76b8b1 (diff)
downloadlibcore-9250fd718bd449cab13681cbc2b31bf65569d31f.zip
libcore-9250fd718bd449cab13681cbc2b31bf65569d31f.tar.gz
libcore-9250fd718bd449cab13681cbc2b31bf65569d31f.tar.bz2
Merge "Move dexCacheStrings from ArtMethod to ArtClass" into lmp-mr1-dev
-rw-r--r--libart/src/main/java/java/lang/Class.java4
-rw-r--r--libart/src/main/java/java/lang/reflect/ArtMethod.java10
2 files changed, 4 insertions, 10 deletions
diff --git a/libart/src/main/java/java/lang/Class.java b/libart/src/main/java/java/lang/Class.java
index 3ac359b..8833776 100644
--- a/libart/src/main/java/java/lang/Class.java
+++ b/libart/src/main/java/java/lang/Class.java
@@ -138,6 +138,9 @@ public final class Class<T> implements Serializable, AnnotatedElement, GenericDe
*/
private transient DexCache dexCache;
+ /** Short-cut to dexCache.strings */
+ private transient String[] dexCacheStrings;
+
/** static, private, and &lt;init&gt; methods. */
private transient ArtMethod[] directMethods;
@@ -453,7 +456,6 @@ public final class Class<T> implements Serializable, AnnotatedElement, GenericDe
* @hide
*/
public String getDexCacheString(Dex dex, int dexStringIndex) {
- String[] dexCacheStrings = dexCache.strings;
String s = dexCacheStrings[dexStringIndex];
if (s == null) {
s = dex.strings().get(dexStringIndex).intern();
diff --git a/libart/src/main/java/java/lang/reflect/ArtMethod.java b/libart/src/main/java/java/lang/reflect/ArtMethod.java
index 07cc30c..95e03c6 100644
--- a/libart/src/main/java/java/lang/reflect/ArtMethod.java
+++ b/libart/src/main/java/java/lang/reflect/ArtMethod.java
@@ -53,9 +53,6 @@ public final class ArtMethod {
/** Short-cut to declaringClass.dexCache.resolvedTypes */
/* package */ Class<?>[] dexCacheResolvedTypes;
- /** Short-cut to declaringClass.dexCache.strings */
- private String[] dexCacheStrings;
-
/** Bits encoding access (e.g. public, private) as well as other runtime specific flags */
private int accessFlags;
@@ -180,12 +177,7 @@ public final class ArtMethod {
* Method we can avoid one indirection.
*/
private String getDexCacheString(Dex dex, int dexStringIndex) {
- String s = (String) dexCacheStrings[dexStringIndex];
- if (s == null) {
- s = dex.strings().get(dexStringIndex).intern();
- dexCacheStrings[dexStringIndex] = s;
- }
- return s;
+ return declaringClass.getDexCacheString(dex, dexStringIndex);
}
/**