diff options
author | Elliott Hughes <enh@google.com> | 2010-02-03 16:02:33 -0800 |
---|---|---|
committer | Elliott Hughes <enh@google.com> | 2010-02-03 16:02:33 -0800 |
commit | 307a6a094ae439b0509161f36b1c260e3f00fc0d (patch) | |
tree | d906a3d1cf0b2a8892576265bed3d821c9c94454 /archive | |
parent | 4d4ca58e669c83e2c4e0a0d49d3d854f6883dc84 (diff) | |
download | libcore-307a6a094ae439b0509161f36b1c260e3f00fc0d.zip libcore-307a6a094ae439b0509161f36b1c260e3f00fc0d.tar.gz libcore-307a6a094ae439b0509161f36b1c260e3f00fc0d.tar.bz2 |
Remove obviously bogus @KnownFailure annotations.
We've already agreed @KnownFailure Must Die (to be replaced by expectations for
DalvikRunner), but some are -- I think -- obviously in need of investigation.
This patch removes @KnownFailure for all cases where the reason looks bogus.
I've left the @KnownFailure annotations in cases where I it looks "reasonable"
in that we simply haven't implemented the functionality (pack200, say), and
a few other cases. Those should probably be done in a separate patch that adds
expectations at the same time.
But these ones, I think, all need investigating. (There's a scary number of
Arabic-related bugs in here, given that we're supposed to be shipping Arabic
in froyo.)
Diffstat (limited to 'archive')
-rw-r--r-- | archive/src/test/java/org/apache/harmony/archive/tests/java/util/jar/ManifestTest.java | 1 | ||||
-rw-r--r-- | archive/src/test/java/org/apache/harmony/archive/tests/java/util/zip/ZipFileTest.java | 2 |
2 files changed, 0 insertions, 3 deletions
diff --git a/archive/src/test/java/org/apache/harmony/archive/tests/java/util/jar/ManifestTest.java b/archive/src/test/java/org/apache/harmony/archive/tests/java/util/jar/ManifestTest.java index 42b2543..a00e480 100644 --- a/archive/src/test/java/org/apache/harmony/archive/tests/java/util/jar/ManifestTest.java +++ b/archive/src/test/java/org/apache/harmony/archive/tests/java/util/jar/ManifestTest.java @@ -418,7 +418,6 @@ public class ManifestTest extends TestCase { method = "Manifest", args = {InputStream.class} ) - @KnownFailure("CharsetDecoder fails with an IllegalStateException") public void testDecoding() throws IOException { Manifest m = getManifest(attJarName); final byte[] bVendor = new byte[] { (byte) 0xd0, (byte) 0x9C, diff --git a/archive/src/test/java/org/apache/harmony/archive/tests/java/util/zip/ZipFileTest.java b/archive/src/test/java/org/apache/harmony/archive/tests/java/util/zip/ZipFileTest.java index fb326a6..f6c810c 100644 --- a/archive/src/test/java/org/apache/harmony/archive/tests/java/util/zip/ZipFileTest.java +++ b/archive/src/test/java/org/apache/harmony/archive/tests/java/util/zip/ZipFileTest.java @@ -456,7 +456,6 @@ public class ZipFileTest extends junit.framework.TestCase { method = "getInputStream", args = {java.util.zip.ZipEntry.class} ) - @KnownFailure("ZipEntry.getInputStream().reset() fails with an IOException") public void test_reset() throws IOException { // read an uncompressed entry ZipEntry zentry = zfile.getEntry("File1.txt"); @@ -503,7 +502,6 @@ public class ZipFileTest extends junit.framework.TestCase { method = "getInputStream", args = {java.util.zip.ZipEntry.class} ) - @KnownFailure("ZipEntry.getInputStream().reset() fails with an IOException") public void test_reset_subtest0() throws IOException { // read an uncompressed entry ZipEntry zentry = zfile.getEntry("File1.txt"); |