diff options
author | Elliott Hughes <enh@google.com> | 2010-02-18 17:20:15 -0800 |
---|---|---|
committer | Elliott Hughes <enh@google.com> | 2010-02-19 10:35:06 -0800 |
commit | 7ee3a061452c5a7e5c8e661219a1f08a14171858 (patch) | |
tree | f995fb4c053e4c68a86909aa72aee284cb39133a /dom/src/test/java | |
parent | 1d1f9244611a8ba3be65795d4ea6e84bcecdb89d (diff) | |
download | libcore-7ee3a061452c5a7e5c8e661219a1f08a14171858.zip libcore-7ee3a061452c5a7e5c8e661219a1f08a14171858.tar.gz libcore-7ee3a061452c5a7e5c8e661219a1f08a14171858.tar.bz2 |
Resync a load of tests with upstream, make our build faster.
I started off with a mission to remove uses of dalvik.annotation.* (stuff
like @TestTargetNew and other useless junk that just makes it harder to
stay in sync with upstream). I wrote a script to go through tests showing
me the diff between what we have and what upstream has, thinking that in
cases where upstream has also added tests, I may as well pull them in at
the same time...
...but I didn't realize how close we were to having dx fill its 1.5GiB heap.
After trying various alternatives, I decided to bite the bullet and break
core-tests up into one .jar per module. This adds parallelism back into this,
the slowest part of our build. (I can do even better, but I'll do that in a
separate patch, preferably after we've merged recent changes from master.)
Only a couple of dependencies were problematic: the worthless TestSuiteFactory
which already contained a comment suggesting we get rid of it, and the fact
that some tests -- most notably the concurrent ones -- also contained main
methods that started the JUnit tty-based TestRunner.
(In the long run, we want to be running the harmony tests directly from a
pristine "svn co" of upstream, using DalvikRunner. But this will be a big
help in the meantime, and starts the work of getting our current copy of
the tests into a state where we can start to extract any meaningful
changes/additions we've made.)
Diffstat (limited to 'dom/src/test/java')
-rw-r--r-- | dom/src/test/java/tests/api/org/w3c/dom/AllTests.java | 2 | ||||
-rw-r--r-- | dom/src/test/java/tests/dom/AllTests.java | 5 |
2 files changed, 5 insertions, 2 deletions
diff --git a/dom/src/test/java/tests/api/org/w3c/dom/AllTests.java b/dom/src/test/java/tests/api/org/w3c/dom/AllTests.java index 677780a..7214d4f 100644 --- a/dom/src/test/java/tests/api/org/w3c/dom/AllTests.java +++ b/dom/src/test/java/tests/api/org/w3c/dom/AllTests.java @@ -28,7 +28,7 @@ public class AllTests { }*/ public static final Test suite() { - TestSuite suite = tests.TestSuiteFactory.createTestSuite(); + TestSuite suite = new TestSuite(); suite.addTest(AllTests_Level1.suite()); suite.addTest(AllTests_Level2.suite()); return suite; diff --git a/dom/src/test/java/tests/dom/AllTests.java b/dom/src/test/java/tests/dom/AllTests.java index 6a5831f..48b362b 100644 --- a/dom/src/test/java/tests/dom/AllTests.java +++ b/dom/src/test/java/tests/dom/AllTests.java @@ -24,7 +24,10 @@ import junit.framework.TestSuite; public class AllTests { public static Test suite() { - TestSuite suite = tests.TestSuiteFactory.createTestSuite(); + TestSuite suite = new TestSuite(); + // BEGIN android-changed: this was only referenced from the xml module! + suite.addTest(tests.api.org.w3c.dom.AllTests.suite()); + // END android-changed suite.addTestSuite(JunitTestCases.class); return suite; } |