Fix harmony java.text test failures.

There were plenty of bad tests here, but there were some real bugs too.

* DecimalFormat was only handling RoundingMode.UNNECESSARY for double
formatting.

* DecimalFormat was not ensuring that it's superclass' fields were
being correctly updated.

* NumberFormat was throwing NPE for a null object because of an
improved detail message, despite being specified to throw IAE.

* We weren't mapping NumberFormat.Field instances to the corresponding icu4c
UNUM_x_FIELD constant, so we weren't actually setting FieldPosition
objects correctly.

* SimpleDateFormat was not formatting milliseconds correctly with 'S'.

* NativeDecimalFormat wasn't handling JNI NewString OOME correctly.

Bug: 2528220
Bug: 3056865
Bug: 3057080
Bug: 3057090
Change-Id: Iac11f902f2e9649e596e7e7b7bc501b13e956fca

1 files changed, 3 insertions, 37 deletions

diff --git a/expectations/brokentests.txt b/expectations/brokentests.txt
index 24813dd..2d028b0 100644
--- a/expectations/brokentests.txt
+++ b/expectations/brokentests.txt
@@ -543,21 +543,14 @@
   substring: "GMT-07:00"
 },
 {
-  description: "This test fails because on Android, RuleBasedCollators default to
-                CANONICAL_DECOMPOSITION, not NO_DECOMPOSITION.",
-  result: EXEC_FAILED,
-  name: "org.apache.harmony.text.tests.java.text.RuleBasedCollatorTest#testEqualsObject",
-  substring: "expected:<0> but was:<1>"
-},
-{
-  description: "These Harmony tests are enforcing a buggy behaviour in TreeMap, presumably to be bug-compatible
+  description: "These Harmony tests are enforcing a buggy behavior in TreeMap, presumably to be bug-compatible
                 with the RI. Our implementation is more conservative and throws on the bogus inputs.",
   result: EXEC_FAILED,
   name: "org.apache.harmony.luni.tests.java.util.TreeMapExtendTest#test_AscendingSubMapKeySet_headSet",
   substring: "java.lang.IllegalArgumentException: 100 not in range (100..109]"
 },
 {
-  description: "These Harmony tests are enforcing a buggy behaviour in TreeMap, presumably to be bug-compatible
+  description: "These Harmony tests are enforcing a buggy behavior in TreeMap, presumably to be bug-compatible
                 with the RI. Our implementation is more conservative and throws on the bogus inputs.",
   result: EXEC_FAILED,
   names: [
@@ -567,7 +560,7 @@
   substring: "java.lang.IllegalArgumentException: null not in range [100..109)"
 },
 {
-  description: "These Harmony tests are enforcing a buggy behaviour in TreeMap, presumably to be bug-compatible
+  description: "These Harmony tests are enforcing a buggy behavior in TreeMap, presumably to be bug-compatible
                 with the RI. Our implementation is more conservative and throws on the bogus inputs.",
   result: EXEC_FAILED,
   names: [
@@ -757,24 +750,6 @@
   substring: "junit.framework.AssertionFailedError: expected:<3> but was:<2>"
 },
 {
-  description: "ICU doesn't provide localized pattern characters, and these tests assume the locale they're using has them.",
-  result: EXEC_FAILED,
-  name: "org.apache.harmony.text.tests.java.text.SimpleDateFormatTest#test_applyLocalizedPatternLjava_lang_String",
-  substring: "java.lang.IllegalArgumentException: Invalid pattern character 'u' in 'GuMtkHmsSEDFwWahKz'"
-},
-{
-  description: "ICU doesn't provide localized pattern characters, and these tests assume the locale they're using has them.",
-  result: EXEC_FAILED,
-  name: "org.apache.harmony.text.tests.java.text.SimpleDateFormatTest#test_toLocalizedPattern",
-  substring: "junit.framework.AssertionFailedError: Wrong pattern: GyMdkHmsSEDFwWahKz"
-},
-{
-  description: "ICU doesn't provide localized pattern characters, and these tests assume the locale they're using has them.",
-  result: EXEC_FAILED,
-  name: "org.apache.harmony.text.tests.java.text.DateFormatSymbolsTest#test_getLocalPatternChars",
-  substring: "junit.framework.ComparisonFailure: Returned incorrect pattern string expected:<...YeugAZvcLQqV> but was:<...Z>"
-},
-{
   description: "we don't support the CharsetProvider spi, so we don't have \"mockCharset00\".",
   result: EXEC_FAILED,
   name: "tests.api.java.nio.charset.CharsetTest#test_availableCharsets",
@@ -838,15 +813,6 @@
   name: "org.apache.harmony.luni.tests.internal.nls.MessagesTest"
 },
 {
-  description: "These test implementation details we don't share.",
-  result: EXEC_FAILED,
-  names: [
-    "org.apache.harmony.text.tests.java.text.BreakIteratorTest#test_getInt",
-    "org.apache.harmony.text.tests.java.text.BreakIteratorTest#test_getLong",
-    "org.apache.harmony.text.tests.java.text.BreakIteratorTest#test_getShort"
-  ]
-},
-{
   description: "These format specifiers are documented to not take flags, but the RI accepts and ignores them.",
   result: EXEC_FAILED,
   name: "org.apache.harmony.luni.tests.java.util.FormatterTest#test_formatLjava_lang_String$Ljava_lang_Object_LineSeparator",