diff options
| author | Jesse Wilson <jessewilson@google.com> | 2010-12-17 15:18:11 -0800 |
|---|---|---|
| committer | Jesse Wilson <jessewilson@google.com> | 2010-12-20 10:48:07 -0800 |
| commit | 6767bdbe6bb1d4542c97868d8df1f71d2414fc62 (patch) | |
| tree | 0345b884df60c2d8eb50f428ec034151905b8ee7 /expectations | |
| parent | 19b9b8115e2946ffbf68148d8755a76b37b082e5 (diff) | |
| download | libcore-6767bdbe6bb1d4542c97868d8df1f71d2414fc62.zip libcore-6767bdbe6bb1d4542c97868d8df1f71d2414fc62.tar.gz libcore-6767bdbe6bb1d4542c97868d8df1f71d2414fc62.tar.bz2 | |
Optimize DefaultHostnameVerifier.
The only behavior change should be a bug fix. There was a heck
"cn.lastIndexOf('.') >= 0" that was always true. This has been
fixed to match the comment "require two dots".
Don't call getDNSSubjectAlts unless necessary.
Errors were created and then dropped. Now they're not created.
strictWithSubDomains was supported but unused. Now it isn't supported.
IP address parsing is now left up to the experts (InetAddress).
No more unnecessary conversions to arrays.
Before & After performance saves ~40% for google.com, which was the
only host that took more than 150 microseconds to verify:
host run us linear runtime %
www.amazon.com baseline 92.6 = 4%
www.amazon.com optimized 26.7 1%
www.google.com baseline 2,457.0 ============================== 100%
www.google.com optimized 1,421.2 ================= 58%
www.ubs.com baseline 143.2 = 6%
www.ubs.com optimized 24.4 1%
Change-Id: I42782bec6a86b95e8fa089aa6edeca45110c2fc4
http://b/2811070
Diffstat (limited to 'expectations')
| -rw-r--r-- | expectations/knownfailures.txt | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/expectations/knownfailures.txt b/expectations/knownfailures.txt index cf155c7..0f73d66 100644 --- a/expectations/knownfailures.txt +++ b/expectations/knownfailures.txt @@ -978,9 +978,9 @@ name: "tests.api.javax.net.ssl.TrustManagerFactory1Test#test_initLjavax_net_ssl_ManagerFactoryParameters" }, { - description: "DefaultHostnameVerifier is broken on Android, fixed in donutburger", - result: EXEC_FAILED, - name: "tests.api.javax.net.ssl.HostnameVerifierTest#testSubjectAlt" + description: "HostnameVerifier doesn't verify IP addresses", + bug: 3299188, + name: "tests.api.javax.net.ssl.HostnameVerifierTest#testVerifyIpAddress" }, { description: "NO SERVER CERTIFICATE FOUND - selectSuite should not pick a suite that needs a certificate if it is missing", |