diff options
author | ccornelius <ccornelius@google.com> | 2014-02-27 14:57:17 -0800 |
---|---|---|
committer | Narayan Kamath <narayan@google.com> | 2014-03-14 09:14:15 +0000 |
commit | 1e768ec282dcc1a5f85a2e78852f7549802e5ccf (patch) | |
tree | 2207fd5fe8b9ca14866e5f7d41bad7ad118b24fb /luni | |
parent | e6e7947cef6e6299d617b8efbe108d1c89a8f91d (diff) | |
download | libcore-1e768ec282dcc1a5f85a2e78852f7549802e5ccf.zip libcore-1e768ec282dcc1a5f85a2e78852f7549802e5ccf.tar.gz libcore-1e768ec282dcc1a5f85a2e78852f7549802e5ccf.tar.bz2 |
Update tests for to handle changes in ICU52.
Mostly changes are data related. These resolve most new issues
found with the update to external/icu4c version 52.
The only exceptions are
- a regression in arabic number parsing (see issue 13410257)
- a regression in bucket labeling for japanese characters (13434905)
Change-Id: I7f865c64556bd0492b67dc6c81b50387a5c19617
Diffstat (limited to 'luni')
8 files changed, 76 insertions, 71 deletions
diff --git a/luni/src/test/java/libcore/icu/AlphabeticIndexTest.java b/luni/src/test/java/libcore/icu/AlphabeticIndexTest.java index 801db4b..98f68e2 100644 --- a/luni/src/test/java/libcore/icu/AlphabeticIndexTest.java +++ b/luni/src/test/java/libcore/icu/AlphabeticIndexTest.java @@ -51,8 +51,12 @@ public class AlphabeticIndexTest extends junit.framework.TestCase { // Kanji (sorts to inflow section) assertHasLabel(ja, "\u65e5", ""); + + // This doesn't work correctly with ICU 52, see b/13434905. + // // http://bugs.icu-project.org/trac/ticket/10423 / http://b/10809397 - assertHasLabel(ja, "\u95c7", ""); + // assertHasLabel(ja, "\u95c7", ""); + // assertHasLabel(ja, "\u308f", "Hirigana wa"); // English assertHasLabel(ja, "Smith", "S"); @@ -106,12 +110,13 @@ public class AlphabeticIndexTest extends junit.framework.TestCase { } public void test_de() throws Exception { - // German: [A-S,Sch,St,T-Z] (no ß or umlauted characters in standard alphabet) + // German: [A-Z] (no ß or umlauted characters in standard alphabet) AlphabeticIndex.ImmutableIndex de = createIndex(Locale.GERMAN); assertHasLabel(de, "ßind", "S"); assertHasLabel(de, "Sacher", "S"); - assertHasLabel(de, "Schiller", "Sch"); - assertHasLabel(de, "Steiff", "St"); + // "Sch" and "St" are also options for lists by last name. + assertHasLabel(de, "Schiller", "S"); + assertHasLabel(de, "Steiff", "S"); } public void test_th() throws Exception { diff --git a/luni/src/test/java/libcore/icu/DateIntervalFormatTest.java b/luni/src/test/java/libcore/icu/DateIntervalFormatTest.java index c8cf572..18228f9 100644 --- a/luni/src/test/java/libcore/icu/DateIntervalFormatTest.java +++ b/luni/src/test/java/libcore/icu/DateIntervalFormatTest.java @@ -16,13 +16,9 @@ package libcore.icu; -import java.util.Arrays; -import java.util.Locale; - import java.util.Calendar; -import java.util.Date; +import java.util.Locale; import java.util.TimeZone; - import static libcore.icu.DateIntervalFormat.*; public class DateIntervalFormatTest extends junit.framework.TestCase { @@ -89,26 +85,26 @@ public class DateIntervalFormatTest extends junit.framework.TestCase { assertEquals("19.01.2009 - 09.02.2012", formatDateRange(de_DE, tz, fixedTime, fixedTime + 3 * YEAR, FORMAT_SHOW_YEAR | FORMAT_NUMERIC_DATE)); assertEquals("1/19/2009", formatDateRange(es_US, tz, fixedTime, fixedTime + HOUR, FORMAT_SHOW_YEAR | FORMAT_NUMERIC_DATE)); - assertEquals("19/1/2009 – 22/1/2009", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * DAY, FORMAT_SHOW_YEAR | FORMAT_NUMERIC_DATE)); - assertEquals("19/1/2009 – 22/4/2009", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * MONTH, FORMAT_SHOW_YEAR | FORMAT_NUMERIC_DATE)); - assertEquals("19/1/2009 – 9/2/2012", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * YEAR, FORMAT_SHOW_YEAR | FORMAT_NUMERIC_DATE)); + assertEquals("19/1/2009–22/1/2009", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * DAY, FORMAT_SHOW_YEAR | FORMAT_NUMERIC_DATE)); + assertEquals("19/1/2009–22/4/2009", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * MONTH, FORMAT_SHOW_YEAR | FORMAT_NUMERIC_DATE)); + assertEquals("19/1/2009–9/2/2012", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * YEAR, FORMAT_SHOW_YEAR | FORMAT_NUMERIC_DATE)); assertEquals("19/1/2009", formatDateRange(es_ES, tz, fixedTime, fixedTime + HOUR, FORMAT_SHOW_YEAR | FORMAT_NUMERIC_DATE)); - assertEquals("19/1/2009 – 22/1/2009", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * DAY, FORMAT_SHOW_YEAR | FORMAT_NUMERIC_DATE)); - assertEquals("19/1/2009 – 22/4/2009", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * MONTH, FORMAT_SHOW_YEAR | FORMAT_NUMERIC_DATE)); - assertEquals("19/1/2009 – 9/2/2012", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * YEAR, FORMAT_SHOW_YEAR | FORMAT_NUMERIC_DATE)); + assertEquals("19/1/2009–22/1/2009", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * DAY, FORMAT_SHOW_YEAR | FORMAT_NUMERIC_DATE)); + assertEquals("19/1/2009–22/4/2009", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * MONTH, FORMAT_SHOW_YEAR | FORMAT_NUMERIC_DATE)); + assertEquals("19/1/2009–9/2/2012", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * YEAR, FORMAT_SHOW_YEAR | FORMAT_NUMERIC_DATE)); // These are some random other test cases I came up with. - assertEquals("January 19–22, 2009", formatDateRange(en_US, tz, fixedTime, fixedTime + 3 * DAY, 0)); - assertEquals("Jan 19–22, 2009", formatDateRange(en_US, tz, fixedTime, fixedTime + 3 * DAY, FORMAT_SHOW_DATE | FORMAT_ABBREV_ALL)); + assertEquals("January 19 – 22, 2009", formatDateRange(en_US, tz, fixedTime, fixedTime + 3 * DAY, 0)); + assertEquals("Jan 19 – 22, 2009", formatDateRange(en_US, tz, fixedTime, fixedTime + 3 * DAY, FORMAT_SHOW_DATE | FORMAT_ABBREV_ALL)); assertEquals("Mon, Jan 19 – Thu, Jan 22, 2009", formatDateRange(en_US, tz, fixedTime, fixedTime + 3 * DAY, FORMAT_SHOW_WEEKDAY | FORMAT_ABBREV_ALL)); assertEquals("Monday, January 19 – Thursday, January 22, 2009", formatDateRange(en_US, tz, fixedTime, fixedTime + 3 * DAY, FORMAT_SHOW_WEEKDAY)); assertEquals("January 19 – April 22, 2009", formatDateRange(en_US, tz, fixedTime, fixedTime + 3 * MONTH, 0)); assertEquals("Jan 19 – Apr 22, 2009", formatDateRange(en_US, tz, fixedTime, fixedTime + 3 * MONTH, FORMAT_SHOW_DATE | FORMAT_ABBREV_ALL)); assertEquals("Mon, Jan 19 – Wed, Apr 22, 2009", formatDateRange(en_US, tz, fixedTime, fixedTime + 3 * MONTH, FORMAT_SHOW_WEEKDAY | FORMAT_ABBREV_ALL)); - assertEquals("January–April 2009", formatDateRange(en_US, tz, fixedTime, fixedTime + 3 * MONTH, FORMAT_NO_MONTH_DAY)); + assertEquals("January – April 2009", formatDateRange(en_US, tz, fixedTime, fixedTime + 3 * MONTH, FORMAT_NO_MONTH_DAY)); assertEquals("Jan 19, 2009 – Feb 9, 2012", formatDateRange(en_US, tz, fixedTime, fixedTime + 3 * YEAR, FORMAT_SHOW_DATE | FORMAT_ABBREV_ALL)); assertEquals("Jan 2009 – Feb 2012", formatDateRange(en_US, tz, fixedTime, fixedTime + 3 * YEAR, FORMAT_NO_MONTH_DAY | FORMAT_ABBREV_ALL)); @@ -135,36 +131,36 @@ public class DateIntervalFormatTest extends junit.framework.TestCase { // The same tests but for es_US. assertEquals("19–22 enero 2009", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * DAY, 0)); - assertEquals("19–22 ene 2009", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * DAY, FORMAT_SHOW_DATE | FORMAT_ABBREV_ALL)); - assertEquals("lun 19 ene – jue 22 ene 2009", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * DAY, FORMAT_SHOW_WEEKDAY | FORMAT_ABBREV_ALL)); - assertEquals("lunes 19 enero – jueves 22 enero 2009", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * DAY, FORMAT_SHOW_WEEKDAY)); + assertEquals("19–22 ene. 2009", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * DAY, FORMAT_SHOW_DATE | FORMAT_ABBREV_ALL)); + assertEquals("lun., 19 ene.–jue., 22 ene. de 2009", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * DAY, FORMAT_SHOW_WEEKDAY | FORMAT_ABBREV_ALL)); + assertEquals("lunes, 19 enero–jueves, 22 enero de 2009", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * DAY, FORMAT_SHOW_WEEKDAY)); - assertEquals("19 enero – 22 abril 2009", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * MONTH, 0)); - assertEquals("19 ene – 22 abr 2009", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * MONTH, FORMAT_SHOW_DATE | FORMAT_ABBREV_ALL)); - assertEquals("lun 19 ene – mié 22 abr 2009", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * MONTH, FORMAT_SHOW_WEEKDAY | FORMAT_ABBREV_ALL)); - assertEquals("enero–abril 2009", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * MONTH, FORMAT_NO_MONTH_DAY)); + assertEquals("19 enero–22 abril de 2009", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * MONTH, 0)); + assertEquals("19 ene.–22 abr. de 2009", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * MONTH, FORMAT_SHOW_DATE | FORMAT_ABBREV_ALL)); + assertEquals("lun., 19 ene.–mié., 22 abr. de 2009", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * MONTH, FORMAT_SHOW_WEEKDAY | FORMAT_ABBREV_ALL)); + assertEquals("enero–abril de 2009", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * MONTH, FORMAT_NO_MONTH_DAY)); - assertEquals("19 ene 2009 – 9 feb 2012", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * YEAR, FORMAT_SHOW_DATE | FORMAT_ABBREV_ALL)); - assertEquals("ene 2009 – feb 2012", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * YEAR, FORMAT_NO_MONTH_DAY | FORMAT_ABBREV_ALL)); - assertEquals("19 enero 2009 – 9 febrero 2012", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * YEAR, 0)); - assertEquals("lunes 19 enero 2009 – jueves 9 febrero 2012", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * YEAR, FORMAT_SHOW_WEEKDAY)); + assertEquals("19 ene. de 2009–9 feb. de 2012", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * YEAR, FORMAT_SHOW_DATE | FORMAT_ABBREV_ALL)); + assertEquals("ene. 2009–feb. 2012", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * YEAR, FORMAT_NO_MONTH_DAY | FORMAT_ABBREV_ALL)); + assertEquals("19 enero de 2009–9 febrero de 2012", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * YEAR, 0)); + assertEquals("lunes, 19 enero de 2009–jueves, 9 febrero de 2012", formatDateRange(es_US, tz, fixedTime, fixedTime + 3 * YEAR, FORMAT_SHOW_WEEKDAY)); // The same tests but for es_ES. assertEquals("19–22 enero 2009", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * DAY, 0)); - assertEquals("19–22 ene 2009", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * DAY, FORMAT_SHOW_DATE | FORMAT_ABBREV_ALL)); - assertEquals("lun 19 ene – jue 22 ene 2009", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * DAY, FORMAT_SHOW_WEEKDAY | FORMAT_ABBREV_ALL)); - assertEquals("lunes 19 enero – jueves 22 enero 2009", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * DAY, FORMAT_SHOW_WEEKDAY)); - - assertEquals("19 enero – 22 abril 2009", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * MONTH, 0)); - assertEquals("19 ene – 22 abr 2009", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * MONTH, FORMAT_SHOW_DATE | FORMAT_ABBREV_ALL)); - assertEquals("lun 19 ene – mié 22 abr 2009", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * MONTH, FORMAT_SHOW_WEEKDAY | FORMAT_ABBREV_ALL)); - assertEquals("enero–abril 2009", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * MONTH, FORMAT_NO_MONTH_DAY)); - - assertEquals("19 ene 2009 – 9 feb 2012", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * YEAR, FORMAT_SHOW_DATE | FORMAT_ABBREV_ALL)); - assertEquals("ene 2009 – feb 2012", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * YEAR, FORMAT_NO_MONTH_DAY | FORMAT_ABBREV_ALL)); - assertEquals("19 enero 2009 – 9 febrero 2012", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * YEAR, 0)); - assertEquals("lunes 19 enero 2009 – jueves 9 febrero 2012", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * YEAR, FORMAT_SHOW_WEEKDAY)); + assertEquals("19–22 ene. 2009", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * DAY, FORMAT_SHOW_DATE | FORMAT_ABBREV_ALL)); + assertEquals("lun., 19 ene.–jue., 22 ene. de 2009", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * DAY, FORMAT_SHOW_WEEKDAY | FORMAT_ABBREV_ALL)); + assertEquals("lunes, 19 enero–jueves, 22 enero de 2009", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * DAY, FORMAT_SHOW_WEEKDAY)); + + assertEquals("19 enero–22 abril de 2009", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * MONTH, 0)); + assertEquals("19 ene.–22 abr. de 2009", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * MONTH, FORMAT_SHOW_DATE | FORMAT_ABBREV_ALL)); + assertEquals("lun., 19 ene.–mié., 22 abr. de 2009", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * MONTH, FORMAT_SHOW_WEEKDAY | FORMAT_ABBREV_ALL)); + assertEquals("enero–abril de 2009", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * MONTH, FORMAT_NO_MONTH_DAY)); + + assertEquals("19 ene. de 2009–9 feb. de 2012", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * YEAR, FORMAT_SHOW_DATE | FORMAT_ABBREV_ALL)); + assertEquals("ene. 2009–feb. 2012", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * YEAR, FORMAT_NO_MONTH_DAY | FORMAT_ABBREV_ALL)); + assertEquals("19 enero de 2009–9 febrero de 2012", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * YEAR, 0)); + assertEquals("lunes, 19 enero de 2009–jueves, 9 febrero de 2012", formatDateRange(es_ES, tz, fixedTime, fixedTime + 3 * YEAR, FORMAT_SHOW_WEEKDAY)); } // http://b/8862241 - we should be able to format dates past 2038. @@ -221,11 +217,11 @@ public class DateIntervalFormatTest extends junit.framework.TestCase { assertEquals("4 PM", formatDateRange(l, utc, teaTime, teaTime, abbr12)); // Abbreviated on-the-hour ranges. - assertEquals("00:00–16:00", formatDateRange(l, utc, midnight, teaTime, abbr24)); + assertEquals("00:00 – 16:00", formatDateRange(l, utc, midnight, teaTime, abbr24)); assertEquals("12 AM – 4 PM", formatDateRange(l, utc, midnight, teaTime, abbr12)); // Abbreviated mixed ranges. - assertEquals("00:00–16:01", formatDateRange(l, utc, midnight, teaTime + MINUTE, abbr24)); + assertEquals("00:00 – 16:01", formatDateRange(l, utc, midnight, teaTime + MINUTE, abbr24)); assertEquals("12:00 AM – 4:01 PM", formatDateRange(l, utc, midnight, teaTime + MINUTE, abbr12)); } @@ -261,7 +257,7 @@ public class DateIntervalFormatTest extends junit.framework.TestCase { int flags = FORMAT_SHOW_TIME | FORMAT_24HOUR | FORMAT_SHOW_DATE; - assertEquals("January 1, 1970, 22:00–00:00", formatDateRange(l, utc, 22 * HOUR, 24 * HOUR, flags)); + assertEquals("January 1, 1970, 22:00 – 00:00", formatDateRange(l, utc, 22 * HOUR, 24 * HOUR, flags)); assertEquals("January 1, 1970, 22:00 – January 2, 1970, 00:30", formatDateRange(l, utc, 22 * HOUR, 24 * HOUR + 30 * MINUTE, flags)); } @@ -361,9 +357,9 @@ public class DateIntervalFormatTest extends junit.framework.TestCase { // the Gregorian calendar, we want to deliberately force icu4c to agree, otherwise we'd have // a mix of calendars throughout an app's UI depending on whether Java or native code formatted // the date. - //assertEquals("یکشنبه ۲۱ بهمن ۱۳۵۸ ه.ش.", formatDateRange(new Locale("fa"), utc, thisYear, thisYear, flags)); - //assertEquals("AP ۱۳۵۸ سلواغه ۲۱, یکشنبه", formatDateRange(new Locale("ps"), utc, thisYear, thisYear, flags)); - //assertEquals("วันอาทิตย์ 10 กุมภาพันธ์ 2523", formatDateRange(new Locale("th"), utc, thisYear, thisYear, flags)); + // assertEquals("یکشنبه ۲۱ بهمن ۱۳۵۸ ه.ش.", formatDateRange(new Locale("fa"), utc, thisYear, thisYear, flags)); + // assertEquals("AP ۱۳۵۸ سلواغه ۲۱, یکشنبه", formatDateRange(new Locale("ps"), utc, thisYear, thisYear, flags)); + // assertEquals("วันอาทิตย์ 10 กุมภาพันธ์ 2523", formatDateRange(new Locale("th"), utc, thisYear, thisYear, flags)); // For now, here are the localized Gregorian strings instead... assertEquals("یکشنبه ۱۰ فوریهٔ ۱۹۸۰", formatDateRange(new Locale("fa"), utc, thisYear, thisYear, flags)); diff --git a/luni/src/test/java/libcore/icu/LocaleDataTest.java b/luni/src/test/java/libcore/icu/LocaleDataTest.java index 27eda86..559744c 100644 --- a/luni/src/test/java/libcore/icu/LocaleDataTest.java +++ b/luni/src/test/java/libcore/icu/LocaleDataTest.java @@ -48,9 +48,9 @@ public class LocaleDataTest extends junit.framework.TestCase { assertEquals("Sun", l.shortStandAloneWeekdayNames[1]); assertEquals("S", l.tinyStandAloneWeekdayNames[1]); - assertEquals("Yesterday", l.yesterday); - assertEquals("Today", l.today); - assertEquals("Tomorrow", l.tomorrow); + assertEquals("yesterday", l.yesterday); + assertEquals("today", l.today); + assertEquals("tomorrow", l.tomorrow); } public void test_de_DE() throws Exception { diff --git a/luni/src/test/java/libcore/icu/NativePluralRulesTest.java b/luni/src/test/java/libcore/icu/NativePluralRulesTest.java index 73699ff..703a94a 100644 --- a/luni/src/test/java/libcore/icu/NativePluralRulesTest.java +++ b/luni/src/test/java/libcore/icu/NativePluralRulesTest.java @@ -21,7 +21,6 @@ import java.util.Locale; public class NativePluralRulesTest extends junit.framework.TestCase { public void testEnglish() throws Exception { NativePluralRules npr = NativePluralRules.forLocale(new Locale("en", "US")); - assertEquals(NativePluralRules.OTHER, npr.quantityForInt(-1)); assertEquals(NativePluralRules.OTHER, npr.quantityForInt(0)); assertEquals(NativePluralRules.ONE, npr.quantityForInt(1)); assertEquals(NativePluralRules.OTHER, npr.quantityForInt(2)); @@ -29,7 +28,6 @@ public class NativePluralRulesTest extends junit.framework.TestCase { public void testCzech() throws Exception { NativePluralRules npr = NativePluralRules.forLocale(new Locale("cs", "CZ")); - assertEquals(NativePluralRules.OTHER, npr.quantityForInt(-1)); assertEquals(NativePluralRules.OTHER, npr.quantityForInt(0)); assertEquals(NativePluralRules.ONE, npr.quantityForInt(1)); assertEquals(NativePluralRules.FEW, npr.quantityForInt(2)); @@ -40,7 +38,6 @@ public class NativePluralRulesTest extends junit.framework.TestCase { public void testArabic() throws Exception { NativePluralRules npr = NativePluralRules.forLocale(new Locale("ar")); - assertEquals(NativePluralRules.OTHER, npr.quantityForInt(-1)); assertEquals(NativePluralRules.ZERO, npr.quantityForInt(0)); assertEquals(NativePluralRules.ONE, npr.quantityForInt(1)); assertEquals(NativePluralRules.TWO, npr.quantityForInt(2)); @@ -62,6 +59,7 @@ public class NativePluralRulesTest extends junit.framework.TestCase { assertEquals(NativePluralRules.ONE, he.quantityForInt(1)); assertEquals(NativePluralRules.TWO, he.quantityForInt(2)); assertEquals(NativePluralRules.OTHER, he.quantityForInt(3)); - assertEquals(NativePluralRules.MANY, he.quantityForInt(10)); + assertEquals(NativePluralRules.OTHER, he.quantityForInt(10)); } } + diff --git a/luni/src/test/java/libcore/java/text/NumberFormatTest.java b/luni/src/test/java/libcore/java/text/NumberFormatTest.java index 32307b7..5862a6c 100644 --- a/luni/src/test/java/libcore/java/text/NumberFormatTest.java +++ b/luni/src/test/java/libcore/java/text/NumberFormatTest.java @@ -66,16 +66,16 @@ public class NumberFormatTest extends junit.framework.TestCase { public void test_getIntegerInstance_ar() throws Exception { NumberFormat numberFormat = NumberFormat.getNumberInstance(new Locale("ar")); - assertEquals("#0.###;#0.###-", ((DecimalFormat) numberFormat).toPattern()); + assertEquals("#,##0.###", ((DecimalFormat) numberFormat).toPattern()); NumberFormat integerFormat = NumberFormat.getIntegerInstance(new Locale("ar")); - assertEquals("#0;#0-", ((DecimalFormat) integerFormat).toPattern()); + assertEquals("#,##0", ((DecimalFormat) integerFormat).toPattern()); } public void test_numberLocalization() throws Exception { Locale arabic = new Locale("ar"); NumberFormat nf = NumberFormat.getNumberInstance(arabic); assertEquals('\u0660', new DecimalFormatSymbols(arabic).getZeroDigit()); - assertEquals("١٢٣٤٥٦٧٨٩٠", nf.format(1234567890)); + assertEquals("١٬٢٣٤٬٥٦٧٬٨٩٠", nf.format(1234567890)); } // Formatting percentages is confusing but deliberate. diff --git a/luni/src/test/java/libcore/java/text/OldNumberFormatTest.java b/luni/src/test/java/libcore/java/text/OldNumberFormatTest.java index b7ae098..47e8694 100644 --- a/luni/src/test/java/libcore/java/text/OldNumberFormatTest.java +++ b/luni/src/test/java/libcore/java/text/OldNumberFormatTest.java @@ -50,10 +50,17 @@ public class OldNumberFormatTest extends TestCase { Locale arLocale = new Locale("ar", "AE"); format = (DecimalFormat) NumberFormat.getIntegerInstance(arLocale); - assertEquals("#0;#0-", format.toPattern()); - assertEquals("\u0666-", format.format(-6)); - assertEquals(new Long(-36), format.parse("36-")); - assertEquals(new Long(-36), format.parseObject("36-")); + assertEquals("#,##0", format.toPattern()); + assertEquals("\u0666\u0667", format.format(67)); + + // TODO: Formatting and parsing of negative numbers in "ar" and + // "ar_AE" is broken with ICU 52. See b/13410257. + // + // assertEquals("\u200f\u0666", format.format(-6)); + // assertEquals(new Long(-36), format.parse("-36")); + // + // New Arabic formats do not support '-' to right of digits. + // assertEquals(new Long(-36), format.parseObject("36-")); assertEquals(0, format.getMaximumFractionDigits()); assertTrue(format.isParseIntegerOnly()); } diff --git a/luni/src/test/java/libcore/java/util/LocaleTest.java b/luni/src/test/java/libcore/java/util/LocaleTest.java index c6aea9e..6a28811 100644 --- a/luni/src/test/java/libcore/java/util/LocaleTest.java +++ b/luni/src/test/java/libcore/java/util/LocaleTest.java @@ -74,12 +74,12 @@ public class LocaleTest extends junit.framework.TestCase { assertEquals("Macau", new Locale("", "MO").getDisplayCountry(Locale.US)); assertEquals("Palestine", new Locale("", "PS").getDisplayCountry(Locale.US)); - assertEquals("Cocos [Keeling] Islands", new Locale("", "CC").getDisplayCountry(Locale.US)); - assertEquals("Congo [DRC]", new Locale("", "CD").getDisplayCountry(Locale.US)); - assertEquals("Congo [Republic]", new Locale("", "CG").getDisplayCountry(Locale.US)); - assertEquals("Falkland Islands [Islas Malvinas]", new Locale("", "FK").getDisplayCountry(Locale.US)); - assertEquals("Macedonia [FYROM]", new Locale("", "MK").getDisplayCountry(Locale.US)); - assertEquals("Myanmar [Burma]", new Locale("", "MM").getDisplayCountry(Locale.US)); + assertEquals("Cocos (Keeling) Islands", new Locale("", "CC").getDisplayCountry(Locale.US)); + assertEquals("Congo (DRC)", new Locale("", "CD").getDisplayCountry(Locale.US)); + assertEquals("Congo (Republic)", new Locale("", "CG").getDisplayCountry(Locale.US)); + assertEquals("Falkland Islands (Islas Malvinas)", new Locale("", "FK").getDisplayCountry(Locale.US)); + assertEquals("Macedonia (FYROM)", new Locale("", "MK").getDisplayCountry(Locale.US)); + assertEquals("Myanmar (Burma)", new Locale("", "MM").getDisplayCountry(Locale.US)); assertEquals("Taiwan", new Locale("", "TW").getDisplayCountry(Locale.US)); } @@ -1135,4 +1135,3 @@ public class LocaleTest extends junit.framework.TestCase { assertEquals("en__#x-fooo-baar", b.build().toString()); } } - diff --git a/luni/src/test/java/libcore/java/util/OldTimeZoneTest.java b/luni/src/test/java/libcore/java/util/OldTimeZoneTest.java index 713e1b5..93bd028 100644 --- a/luni/src/test/java/libcore/java/util/OldTimeZoneTest.java +++ b/luni/src/test/java/libcore/java/util/OldTimeZoneTest.java @@ -92,7 +92,7 @@ public class OldTimeZoneTest extends TestCase { public void test_getDisplayNameLjava_util_Locale() { TimeZone tz = TimeZone.getTimeZone("America/Los_Angeles"); assertEquals("Pacific Standard Time", tz.getDisplayName(new Locale("US"))); - assertEquals("heure normale du Pacifique", tz.getDisplayName(Locale.FRANCE)); + assertEquals("heure normale du Pacifique nord-américain", tz.getDisplayName(Locale.FRANCE)); } public void test_getDisplayNameZI() { @@ -113,7 +113,7 @@ public class OldTimeZoneTest extends TestCase { // ICU zone/root.txt patched to allow metazone names. assertEquals("PST", tz.getDisplayName(false, 0, Locale.FRANCE)); assertEquals("heure avanc\u00e9e du Pacifique", tz.getDisplayName(true, 1, Locale.FRANCE)); - assertEquals("heure normale du Pacifique", tz.getDisplayName(false, 1, Locale.FRANCE)); + assertEquals("heure normale du Pacifique nord-américain", tz.getDisplayName(false, 1, Locale.FRANCE)); } public void test_getID() { |