| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Bug: https://code.google.com/p/android/issues/detail?id=68924
Change-Id: If687c3b02ae630097d5e4b9603acec19732a7dcc
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- We should set features on a parser only if the feature
value is true. I.e, we guarantee that we'll never call
XmlPullParser.setFeature(..., false).
- In change 0363556bad8930a, we didn't consider the fact
that apps could extend XmlPullParserFactory and modify
protected fields to change the parser / serializer that's
instantiated. I've reinstated this feature, despite the
fact that it's a particularly pointless feature on a
more-or-less pointless public API. Apps can and should
instantiate their own parser instances directly instead
of going through this factory.
bug: 12956724
Change-Id: I793eba335b5385eb641e023b3613bba4515a85bf
|
|
|
|
|
| |
Bug: https://code.google.com/p/android/issues/detail?id=62919
Change-Id: Iadb85c25ec7e07ee245b009f5fb848c8228924a1
|
|
|
|
|
|
| |
Bring back fields that were never used but are public APIs.
Change-Id: I81d312f53745c03da450f599070ae0f5ddd5a81a
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since we're hard coding KXmlParser and KXmlSerializer
anyway, we might as well do it more directly.
Also add a trivial unit test for this method.
NOTE: This change preserves existing behaviour and doesn't
throw from #newInstance if the parser class couldn't be
found or instantiated. We instead throw from newPullParser or
newSerializer as appropriate.
Change-Id: Ic0c86e67691b8e662d95363bbe597d3abb7c3642
|
|
|
|
| |
Change-Id: I5288c5c1f6ce094bcac2792f6fa7fc6a455f756a
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We used to have 2 different implementations of XmlPullParser and
each of them behaved differently if you called next() after
receiving the END_DOCUMENT token:
- Parsers returned from XmlPullParserFactory didn't throw
- Parsers returned from android.util.Xml did throw
When we went to a single implementation the behavior changed for
android.util.Xml users. Unfortunately the change went from being
consistent-with-the-docs to not. Rather than changing the behavior
I'm being a weasel and changing the docs! That way we aren't
promising something we cannot deliver.
Bug: http://code.google.com/p/android/issues/detail?id=29931
Change-Id: I0e72e79270b92ecc0fdb5bf64c97fa50d2bdb81c
|
|
|
|
|
| |
Bug: http://code.google.com/p/android/issues/detail?id=29028
Change-Id: I25464730869499369fb7ec8e282ba5c67ebe909f
|
|
|
|
|
| |
Bug: http://code.google.com/p/android/issues/detail?id=21425
Change-Id: I4c69d67bb8bfdf3f78359d800860d5dc2e2e349f
|
|
|
|
|
|
| |
"Creating new instances of java.lang.Boolean wastes memory."
Change-Id: I954ea1497e924ae9008fe4e47762008f1d1c8561
|
|
|
|
| |
Change-Id: Ia2c621d8a9dfe04cd55aac652d1ac9ea4398afd1
|
|
|
|
|
|
|
| |
Originally reported here:
http://groups.google.com/group/android-platform/browse_thread/thread/6020aee5f01f21df/afac4ce1a0184788?show_docid=afac4ce1a0184788
Change-Id: I378a441117fdf41e74d91ba8fef8ac9abf5a5275
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I benchmarked this on four files:
size file
268 rhapsody authorization
29489 picasa sync (for gallery)
101129 amazon mp3 search results
103855 RSS feed
The performance regressed for the 268-byte file from 1.44ms to 1.56ms.
Small files are important and I intend to follow-up to bring this back
into line.
For the other files, the improvements for pull parsing were 22%, 34% and 29%.
Improvements for DOM parsing were 17%, 23% and 21%.
All but the 268-byte document now parse faster with Kxml than with Expat.
101129 byte amazon mp3 search results 29489 byte picasa sync dat 268 byte rhapsody authentication 103855 byte RSS feed
benchmark run us linear runtime us linear runtime us linear runtime us linear runtime
Dom ready to commit 174,580 ======================== 40,964 ======================= 1,968 =========================== 130,814 =======================
Dom baseline 210,256 ============================== 53,227 ============================== 2,183 ============================== 164,708 =============================
ExpatPull ready to commit 129,776 ================== 21,621 ============ 734 ========== 86,799 ===============
ExpatPull baseline 130,078 ================== 21,700 ============ 759 ========== 85,578 ===============
KxmlPull ready to commit 88,716 ============ 20,578 =========== 1,560 ===================== 58,567 ==========
KxmlPull baseline 114,317 ================ 31,040 ================= 1,443 =================== 82,478 ===============
Change-Id: I98b7f979c2f926e25c72541bf9f5036f097e8d91
http://b/3090550
|
|
|
|
|
|
|
|
|
| |
Motivation: in preparation to refactor the Kxml code I'd like
to bring this code to a style consistent with the rest of
Android. This code style currently disagrees with my toolchain.
Change-Id: Ibd24570c131e792532e46f7f44c64abac3a6979a
http://b/3090550
|
|\
| |
| |
| |
| |
| |
| | |
Merge commit '3d66704483f1b8ea8b6eea1939f02508c551fd62'
* commit '3d66704483f1b8ea8b6eea1939f02508c551fd62':
add meta-files about 3rd party projects
|
| |
| |
| |
| | |
Change-Id: Ib22265632a3be569eeab0320021365b2d80a805e
|
|/
|
|
|
|
| |
Gentlemen, you may now set your editors to "strip trailing whitespace"...
Change-Id: I85b2f6c80e5fbef1af6cab11789790b078c11b1b
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were allowing arbitrary characters to be output (which, surprisingly,
XML does not), and we weren't correctly escaping CDATA sections that
contained "]]>".
Pull out some of my test helpers from DocumentBuilderTest into Support_Xml,
because they're more generally useful when writing tests involving XML.
Also correct a bunch of spelling mistakes in XmlSerializer's javadoc, since
I happened to be reading through.
|
| |
|
|
|
|
| |
Bugs: 2099642, 2099637
|
| |
|
| |
|
|
|