Fix up AutoFill profile editor UI in portrait mode

Create layout-port version of the autofill profile editor that extends
vertically rather than horizontally.

In both portrait and landscape, make the "Save profile" button
always visible, remove the "cancel" button as there are already several
ways to leave the activity without saving changes and move the "Delete
profile" button to the options menu.

Change-Id: I3b03c998bc8cb005f066733a3b6979a03396f31f

1 files changed, 216 insertions, 226 deletions

diff --git a/res/layout/autofill_settings_fragment.xml b/res/layout/autofill_settings_fragment.xml
index b92c149..8c90dd7 100644
--- a/res/layout/autofill_settings_fragment.xml
+++ b/res/layout/autofill_settings_fragment.xml
@@ -13,256 +13,246 @@
      See the License for the specific language governing permissions and
      limitations under the License.
 -->
-
-<ScrollView xmlns:android="http://schemas.android.com/apk/res/android"
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
     android:layout_width="match_parent"
-    android:layout_height="match_parent">
+    android:layout_height="match_parent"
+    android:orientation="vertical">
 
-    <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    <ScrollView xmlns:android="http://schemas.android.com/apk/res/android"
         android:layout_width="match_parent"
-        android:layout_height="match_parent"
-        android:orientation="vertical">
+        android:layout_height="0px"
+        android:layout_weight="1">
 
-        <View
-            android:layout_height="10dip"
-            android:layout_width="match_parent" />
+        <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+            android:layout_width="match_parent"
+            android:layout_height="match_parent"
+            android:orientation="vertical">
 
-        <TextView
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:textAppearance="?android:attr/textAppearanceMedium"
-            android:text="@string/autofill_profile_editor_heading" />
+            <View
+                android:layout_height="10dip"
+                android:layout_width="match_parent" />
+
+            <TextView
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:textAppearance="?android:attr/textAppearanceMedium"
+                android:text="@string/autofill_profile_editor_heading" />
 
-        <View
-            android:layout_height="12dip"
-            android:layout_width="match_parent" />
+            <View
+                android:layout_height="12dip"
+                android:layout_width="match_parent" />
 
-        <TableLayout xmlns:android="http://schemas.android.com/apk/res/android"
-            android:layout_width="match_parent"
-            android:layout_height="wrap_content"
-            android:shrinkColumns="1"
-            android:stretchColumns="1">
-            <TableRow>
-                <TextView
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:gravity="center_vertical"
-                    android:layout_margin="2dip"
-                    android:textAppearance="?android:attr/textAppearanceMedium"
-                    android:text="@string/autofill_profile_editor_name" />
-                <EditText android:id="@+id/autofill_profile_editor_name_edit"
-                    android:layout_width="match_parent"
-                    android:layout_height="wrap_content"
-                    android:gravity="center_vertical"
-                    android:layout_margin="2dip"
-                    android:textAppearance="?android:attr/textAppearanceMedium"
-                    android:inputType="textPersonName|textCapWords"
-                    android:singleLine="true" />
-            </TableRow>
-            <TableRow>
-                <TextView
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:gravity="center_vertical"
-                    android:layout_margin="2dip"
-                    android:textAppearance="?android:attr/textAppearanceMedium"
-                    android:text="@string/autofill_profile_editor_company_name" />
-                <EditText android:id="@+id/autofill_profile_editor_company_name_edit"
-                    android:layout_width="match_parent"
-                    android:layout_height="wrap_content"
-                    android:gravity="center_vertical"
-                    android:layout_margin="2dip"
-                    android:textAppearance="?android:attr/textAppearanceMedium"
-                    android:inputType="textCapWords"
-                    android:singleLine="true" />
-            </TableRow>
-            <TableRow>
-                <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:layout_margin="2dip"
-                    android:orientation="vertical">
+            <TableLayout xmlns:android="http://schemas.android.com/apk/res/android"
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:shrinkColumns="1"
+                android:stretchColumns="1">
+                <TableRow>
                     <TextView
                         android:layout_width="wrap_content"
                         android:layout_height="wrap_content"
                         android:gravity="center_vertical"
+                        android:layout_margin="2dip"
                         android:textAppearance="?android:attr/textAppearanceMedium"
-                        android:text="@string/autofill_profile_editor_address_line_1" />
-                     <TextView
+                        android:text="@string/autofill_profile_editor_name" />
+                    <EditText android:id="@+id/autofill_profile_editor_name_edit"
+                        android:layout_width="match_parent"
+                        android:layout_height="wrap_content"
+                        android:gravity="center_vertical"
+                        android:layout_margin="2dip"
+                        android:textAppearance="?android:attr/textAppearanceMedium"
+                        android:inputType="textPersonName|textCapWords"
+                        android:singleLine="true" />
+                </TableRow>
+                <TableRow>
+                    <TextView
                         android:layout_width="wrap_content"
                         android:layout_height="wrap_content"
                         android:gravity="center_vertical"
-                        android:textAppearance="?android:attr/textAppearanceSmall"
-                        android:text="@string/autofill_profile_editor_address_line_1_hint" />
-                </LinearLayout>
-                <EditText android:id="@+id/autofill_profile_editor_address_line_1_edit"
-                    android:gravity="center_vertical"
-                    android:layout_margin="2dip"
-                    android:textAppearance="?android:attr/textAppearanceMedium"
-                    android:inputType="textCapWords"
-                    android:singleLine="true" />
-            </TableRow>
-            <TableRow>
-                <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:layout_margin="2dip"
-                    android:orientation="vertical">
+                        android:layout_margin="2dip"
+                        android:textAppearance="?android:attr/textAppearanceMedium"
+                        android:text="@string/autofill_profile_editor_company_name" />
+                    <EditText android:id="@+id/autofill_profile_editor_company_name_edit"
+                        android:layout_width="match_parent"
+                        android:layout_height="wrap_content"
+                        android:gravity="center_vertical"
+                        android:layout_margin="2dip"
+                        android:textAppearance="?android:attr/textAppearanceMedium"
+                        android:inputType="textCapWords"
+                        android:singleLine="true" />
+                </TableRow>
+                <TableRow>
+                    <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+                        android:layout_width="wrap_content"
+                        android:layout_height="wrap_content"
+                        android:layout_margin="2dip"
+                        android:orientation="vertical">
+                        <TextView
+                            android:layout_width="wrap_content"
+                            android:layout_height="wrap_content"
+                            android:gravity="center_vertical"
+                            android:textAppearance="?android:attr/textAppearanceMedium"
+                            android:text="@string/autofill_profile_editor_address_line_1" />
+                         <TextView
+                            android:layout_width="wrap_content"
+                            android:layout_height="wrap_content"
+                            android:gravity="center_vertical"
+                            android:textAppearance="?android:attr/textAppearanceSmall"
+                            android:text="@string/autofill_profile_editor_address_line_1_hint" />
+                    </LinearLayout>
+                    <EditText android:id="@+id/autofill_profile_editor_address_line_1_edit"
+                        android:layout_width="match_parent"
+                        android:layout_height="wrap_content"
+                        android:gravity="center_vertical"
+                        android:layout_margin="2dip"
+                        android:textAppearance="?android:attr/textAppearanceMedium"
+                        android:inputType="textCapWords"
+                        android:singleLine="true" />
+                </TableRow>
+                <TableRow>
+                    <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+                        android:layout_width="wrap_content"
+                        android:layout_height="wrap_content"
+                        android:layout_margin="2dip"
+                        android:orientation="vertical">
+                        <TextView
+                            android:layout_width="wrap_content"
+                            android:layout_height="wrap_content"
+                            android:gravity="center_vertical"
+                            android:textAppearance="?android:attr/textAppearanceMedium"
+                            android:text="@string/autofill_profile_editor_address_line_2" />
+                         <TextView
+                            android:layout_width="wrap_content"
+                            android:layout_height="wrap_content"
+                            android:gravity="center_vertical"
+                            android:textAppearance="?android:attr/textAppearanceSmall"
+                            android:text="@string/autofill_profile_editor_address_line_2_hint" />
+                    </LinearLayout>
+                    <EditText android:id="@+id/autofill_profile_editor_address_line_2_edit"
+                        android:layout_width="match_parent"
+                        android:layout_height="wrap_content"
+                        android:gravity="bottom"
+                        android:layout_margin="2dip"
+                        android:textAppearance="?android:attr/textAppearanceMedium"
+                        android:inputType="textCapWords"
+                        android:singleLine="true" />
+                </TableRow>
+                <TableRow>
+                    <TextView
+                        android:layout_width="wrap_content"
+                        android:layout_height="wrap_content"
+                        android:gravity="center_vertical"
+                        android:layout_margin="2dip"
+                        android:textAppearance="?android:attr/textAppearanceMedium"
+                        android:text="@string/autofill_profile_editor_city" />
+                    <EditText android:id="@+id/autofill_profile_editor_city_edit"
+                        android:layout_width="match_parent"
+                        android:layout_height="wrap_content"
+                        android:gravity="center_vertical"
+                        android:layout_margin="2dip"
+                        android:inputType="textCapWords"
+                        android:textAppearance="?android:attr/textAppearanceMedium"
+                        android:singleLine="true" />
+                </TableRow>
+                <TableRow>
                     <TextView
                         android:layout_width="wrap_content"
                         android:layout_height="wrap_content"
                         android:gravity="center_vertical"
+                        android:layout_margin="2dip"
                         android:textAppearance="?android:attr/textAppearanceMedium"
-                        android:text="@string/autofill_profile_editor_address_line_2" />
-                     <TextView
+                        android:text="@string/autofill_profile_editor_state" />
+                    <EditText android:id="@+id/autofill_profile_editor_state_edit"
+                        android:layout_width="match_parent"
+                        android:layout_height="wrap_content"
+                        android:gravity="center_vertical"
+                        android:layout_margin="2dip"
+                        android:inputType="textCapWords"
+                        android:textAppearance="?android:attr/textAppearanceMedium"
+                        android:singleLine="true" />
+                </TableRow>
+                <TableRow>
+                    <TextView
                         android:layout_width="wrap_content"
                         android:layout_height="wrap_content"
                         android:gravity="center_vertical"
-                        android:textAppearance="?android:attr/textAppearanceSmall"
-                        android:text="@string/autofill_profile_editor_address_line_2_hint" />
-                </LinearLayout>
-                <EditText android:id="@+id/autofill_profile_editor_address_line_2_edit"
-                    android:layout_width="match_parent"
-                    android:layout_height="wrap_content"
-                    android:gravity="bottom"
-                    android:layout_margin="2dip"
-                    android:textAppearance="?android:attr/textAppearanceMedium"
-                    android:inputType="textCapWords"
-                    android:singleLine="true" />
-            </TableRow>
-            <TableRow>
-                <TextView
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:gravity="center_vertical"
-                    android:layout_margin="2dip"
-                    android:textAppearance="?android:attr/textAppearanceMedium"
-                    android:text="@string/autofill_profile_editor_city" />
-                <EditText android:id="@+id/autofill_profile_editor_city_edit"
-                    android:layout_width="match_parent"
-                    android:layout_height="wrap_content"
-                    android:gravity="center_vertical"
-                    android:layout_margin="2dip"
-                    android:inputType="textCapWords"
-                    android:textAppearance="?android:attr/textAppearanceMedium"
-                    android:singleLine="true" />
-            </TableRow>
-            <TableRow>
-                <TextView
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:gravity="center_vertical"
-                    android:layout_margin="2dip"
-                    android:textAppearance="?android:attr/textAppearanceMedium"
-                    android:text="@string/autofill_profile_editor_state" />
-                <EditText android:id="@+id/autofill_profile_editor_state_edit"
-                    android:layout_width="match_parent"
-                    android:layout_height="wrap_content"
-                    android:gravity="center_vertical"
-                    android:layout_margin="2dip"
-                    android:inputType="textCapWords"
-                    android:textAppearance="?android:attr/textAppearanceMedium"
-                    android:singleLine="true" />
-            </TableRow>
-            <TableRow>
-                <TextView
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:gravity="center_vertical"
-                    android:layout_margin="2dip"
-                    android:textAppearance="?android:attr/textAppearanceMedium"
-                    android:text="@string/autofill_profile_editor_zip_code" />
-                <EditText android:id="@+id/autofill_profile_editor_zip_code_edit"
-                    android:layout_width="match_parent"
-                    android:layout_height="wrap_content"
-                    android:gravity="center_vertical"
-                    android:layout_margin="2dip"
-                    android:inputType="textCapCharacters"
-                    android:textAppearance="?android:attr/textAppearanceMedium"
-                    android:singleLine="true" />
-            </TableRow>
-            <TableRow>
-                <TextView
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:gravity="center_vertical"
-                    android:layout_margin="2dip"
-                    android:textAppearance="?android:attr/textAppearanceMedium"
-                    android:text="@string/autofill_profile_editor_country" />
-                <EditText android:id="@+id/autofill_profile_editor_country_edit"
-                    android:layout_width="match_parent"
-                    android:layout_height="wrap_content"
-                    android:gravity="center_vertical"
-                    android:layout_margin="2dip"
-                    android:inputType="textCapWords"
-                    android:textAppearance="?android:attr/textAppearanceMedium"
-                    android:singleLine="true" />
-            </TableRow>
-            <TableRow>
-                <TextView
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:gravity="center_vertical"
-                    android:layout_margin="2dip"
-                    android:textAppearance="?android:attr/textAppearanceMedium"
-                    android:text="@string/autofill_profile_editor_phone_number" />
-                <EditText android:id="@+id/autofill_profile_editor_phone_number_edit"
-                    android:layout_width="match_parent"
-                    android:layout_height="wrap_content"
-                    android:gravity="center_vertical"
-                    android:layout_margin="2dip"
-                    android:textAppearance="?android:attr/textAppearanceMedium"
-                    android:singleLine="true"
-                    android:phoneNumber="true" />
-            </TableRow>
-            <TableRow>
-                <TextView
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:gravity="center_vertical"
-                    android:layout_margin="2dip"
-                    android:textAppearance="?android:attr/textAppearanceMedium"
-                    android:text="@string/autofill_profile_editor_email_address" />
-                <EditText android:id="@+id/autofill_profile_editor_email_address_edit"
-                    android:layout_width="match_parent"
-                    android:layout_height="wrap_content"
-                    android:gravity="center_vertical"
-                    android:layout_margin="2dip"
-                    android:textAppearance="?android:attr/textAppearanceMedium"
-                    android:inputType="textEmailAddress"
-                    android:singleLine="true" />
-            </TableRow>
-        </TableLayout>
+                        android:layout_margin="2dip"
+                        android:textAppearance="?android:attr/textAppearanceMedium"
+                        android:text="@string/autofill_profile_editor_zip_code" />
+                    <EditText android:id="@+id/autofill_profile_editor_zip_code_edit"
+                        android:layout_width="match_parent"
+                        android:layout_height="wrap_content"
+                        android:gravity="center_vertical"
+                        android:layout_margin="2dip"
+                        android:inputType="textCapCharacters"
+                        android:textAppearance="?android:attr/textAppearanceMedium"
+                        android:singleLine="true" />
+                </TableRow>
+                <TableRow>
+                    <TextView
+                        android:layout_width="wrap_content"
+                        android:layout_height="wrap_content"
+                        android:gravity="center_vertical"
+                        android:layout_margin="2dip"
+                        android:textAppearance="?android:attr/textAppearanceMedium"
+                        android:text="@string/autofill_profile_editor_country" />
+                    <EditText android:id="@+id/autofill_profile_editor_country_edit"
+                        android:layout_width="match_parent"
+                        android:layout_height="wrap_content"
+                        android:gravity="center_vertical"
+                        android:layout_margin="2dip"
+                        android:inputType="textCapWords"
+                        android:textAppearance="?android:attr/textAppearanceMedium"
+                        android:singleLine="true" />
+                </TableRow>
+                <TableRow>
+                    <TextView
+                        android:layout_width="wrap_content"
+                        android:layout_height="wrap_content"
+                        android:gravity="center_vertical"
+                        android:layout_margin="2dip"
+                        android:textAppearance="?android:attr/textAppearanceMedium"
+                        android:text="@string/autofill_profile_editor_phone_number" />
+                    <EditText android:id="@+id/autofill_profile_editor_phone_number_edit"
+                        android:layout_width="match_parent"
+                        android:layout_height="wrap_content"
+                        android:gravity="center_vertical"
+                        android:layout_margin="2dip"
+                        android:textAppearance="?android:attr/textAppearanceMedium"
+                        android:singleLine="true"
+                        android:phoneNumber="true" />
+                </TableRow>
+                <TableRow>
+                    <TextView
+                        android:layout_width="wrap_content"
+                        android:layout_height="wrap_content"
+                        android:gravity="center_vertical"
+                        android:layout_margin="2dip"
+                        android:textAppearance="?android:attr/textAppearanceMedium"
+                        android:text="@string/autofill_profile_editor_email_address" />
+                    <EditText android:id="@+id/autofill_profile_editor_email_address_edit"
+                        android:layout_width="match_parent"
+                        android:layout_height="wrap_content"
+                        android:gravity="center_vertical"
+                        android:layout_margin="2dip"
+                        android:textAppearance="?android:attr/textAppearanceMedium"
+                        android:inputType="textEmailAddress"
+                        android:singleLine="true" />
+                </TableRow>
+            </TableLayout>
+       </LinearLayout>
+    </ScrollView>
 
-        <View
-            android:layout_height="12dip"
-            android:layout_width="match_parent" />
+    <View
+        android:layout_height="12dip"
+        android:layout_width="match_parent" />
 
-        <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-            android:layout_width="match_parent"
-            android:layout_height="wrap_content"
-            android:orientation="horizontal"
-            android:gravity="center">
-            <Button
-                android:id="@+id/autofill_profile_editor_save_button"
-                android:layout_width="wrap_content"
-                android:layout_height="wrap_content"
-                android:text="@string/autofill_profile_editor_save_profile"
-                android:textAppearance="?android:attr/textAppearanceMedium" />
+    <Button
+        android:id="@+id/autofill_profile_editor_save_button"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:text="@string/autofill_profile_editor_save_profile"
+        android:textAppearance="?android:attr/textAppearanceMedium" />
 
-            <Button
-                android:id="@+id/autofill_profile_editor_cancel_button"
-                android:layout_width="wrap_content"
-                android:layout_height="wrap_content"
-                android:text="@string/cancel"
-                android:textAppearance="?android:attr/textAppearanceMedium" />
+</LinearLayout>
 
-            <Button
-                android:id="@+id/autofill_profile_editor_delete_button"
-                android:layout_width="wrap_content"
-                android:layout_height="wrap_content"
-                android:text="@string/autofill_profile_editor_delete_profile"
-                android:textAppearance="?android:attr/textAppearanceMedium" />
-        </LinearLayout>
-    </LinearLayout>
-</ScrollView>