summaryrefslogtreecommitdiffstats
path: root/src/com/android/browser
diff options
context:
space:
mode:
authorMichael Kolb <kolby@google.com>2011-08-15 16:53:32 -0700
committerAndroid (Google) Code Review <android-gerrit@google.com>2011-08-15 16:53:32 -0700
commit73be9db12f41f8cf3625a9dd7f5ddcf91504cfcd (patch)
tree55b038b6c4548d28e3d8e6cea6c67f2481a07da7 /src/com/android/browser
parent51179c6dcaf0a5de7bb7fcee4e0d343bd2d44221 (diff)
parent8a009498bfca64556c2082cbb32f68506d6962db (diff)
downloadpackages_apps_Browser-73be9db12f41f8cf3625a9dd7f5ddcf91504cfcd.zip
packages_apps_Browser-73be9db12f41f8cf3625a9dd7f5ddcf91504cfcd.tar.gz
packages_apps_Browser-73be9db12f41f8cf3625a9dd7f5ddcf91504cfcd.tar.bz2
Merge "Fix monkey bug"
Diffstat (limited to 'src/com/android/browser')
-rw-r--r--src/com/android/browser/Controller.java19
-rw-r--r--src/com/android/browser/PhoneUi.java2
2 files changed, 16 insertions, 5 deletions
diff --git a/src/com/android/browser/Controller.java b/src/com/android/browser/Controller.java
index 3f126c0..24072c9 100644
--- a/src/com/android/browser/Controller.java
+++ b/src/com/android/browser/Controller.java
@@ -2684,23 +2684,32 @@ public class Controller
}
public boolean dispatchKeyEvent(KeyEvent event) {
- return mBlockEvents;
+ return mBlockEvents || hasNoActiveTab();
}
public boolean dispatchKeyShortcutEvent(KeyEvent event) {
- return mBlockEvents;
+ return mBlockEvents || hasNoActiveTab();
}
public boolean dispatchTouchEvent(MotionEvent ev) {
- return mBlockEvents;
+ return mBlockEvents || hasNoActiveTab();
}
public boolean dispatchTrackballEvent(MotionEvent ev) {
- return mBlockEvents;
+ return mBlockEvents || hasNoActiveTab();
}
public boolean dispatchGenericMotionEvent(MotionEvent ev) {
- return mBlockEvents;
+ return mBlockEvents || hasNoActiveTab();
+ }
+
+ private boolean hasNoActiveTab() {
+ Tab tab = getCurrentTab();
+ if (tab == null) {
+ Log.w(LOGTAG, "Received event with no active tab. Tab count: "
+ + mTabControl.getTabCount());
+ }
+ return tab == null;
}
}
diff --git a/src/com/android/browser/PhoneUi.java b/src/com/android/browser/PhoneUi.java
index d77fcdb..23d7abb 100644
--- a/src/com/android/browser/PhoneUi.java
+++ b/src/com/android/browser/PhoneUi.java
@@ -329,10 +329,12 @@ public class PhoneUi extends BaseUi {
final Tab tab = mNavScreen.getSelectedTab();
if ((tab != null) && !animate) {
finishAnimateOut(tab);
+ return;
}
NavTabView tabview = (NavTabView) mNavScreen.getSelectedTabView();
if (tabview == null) {
finishAnimateOut(tab);
+ return;
}
mUiController.setBlockEvents(true);
mUiController.setActiveTab(tab);