summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZoltan Szatmary-Ban <szatmz@google.com>2015-07-09 15:37:26 +0100
committerZoltan Szatmary-Ban <szatmz@google.com>2015-07-09 15:37:26 +0100
commit4bbe3d1fb66a99bfdf4cad8f2e77df23dccebbbd (patch)
treebfb1d70650f06c48985acfc0af173cb08415af2f
parent93b1a5a974f723f5aa463162b1f5aa43338f8c2e (diff)
downloadpackages_apps_Settings-4bbe3d1fb66a99bfdf4cad8f2e77df23dccebbbd.zip
packages_apps_Settings-4bbe3d1fb66a99bfdf4cad8f2e77df23dccebbbd.tar.gz
packages_apps_Settings-4bbe3d1fb66a99bfdf4cad8f2e77df23dccebbbd.tar.bz2
Update all shown preferences in Settings > Storage
This is achieved by iterating through the pool of StorageItemPreferences up to the index of the last shown one, instead of iterating through the preferences of the screen which may miss preferences inside other top-level preference groups. Bug: 22353561 Change-Id: I2293a7949a5becfb506d6b7965f8db2f11845756
-rw-r--r--src/com/android/settings/deviceinfo/PrivateVolumeSettings.java10
1 files changed, 2 insertions, 8 deletions
diff --git a/src/com/android/settings/deviceinfo/PrivateVolumeSettings.java b/src/com/android/settings/deviceinfo/PrivateVolumeSettings.java
index cf62014..991aeb7 100644
--- a/src/com/android/settings/deviceinfo/PrivateVolumeSettings.java
+++ b/src/com/android/settings/deviceinfo/PrivateVolumeSettings.java
@@ -467,14 +467,8 @@ public class PrivateVolumeSettings extends SettingsPreferenceFragment {
};
private void updateDetails(MeasurementDetails details) {
- PreferenceScreen screen = getPreferenceScreen();
- final int preferenceCount = screen.getPreferenceCount();
- for (int i = 0; i < preferenceCount; ++i) {
- final Preference pref = screen.getPreference(i);
- if (!(pref instanceof StorageItemPreference)) {
- continue;
- }
- StorageItemPreference item = (StorageItemPreference)pref;
+ for (int i = 0; i < mItemPoolIndex; ++i) {
+ StorageItemPreference item = mItemPreferencePool.get(i);
final int userId = item.userHandle;
final int itemTitleId = item.getTitleRes();
switch (itemTitleId) {