summaryrefslogtreecommitdiffstats
path: root/src/com/android/settings/cyanogenmod
diff options
context:
space:
mode:
authorSTELIX <ssspinni@gmail.com>2014-12-09 16:11:05 +0100
committerGerrit Code Review <gerrit@cyanogenmod.org>2015-11-24 17:09:17 -0800
commit4a806aef49b33f8c823983b9fac120f9b9b837d9 (patch)
tree3eab37a6c93738a1f130114c5bdb0320298aecb2 /src/com/android/settings/cyanogenmod
parent5f350518a2aec87c057152191eddddad21083d1c (diff)
downloadpackages_apps_Settings-4a806aef49b33f8c823983b9fac120f9b9b837d9.zip
packages_apps_Settings-4a806aef49b33f8c823983b9fac120f9b9b837d9.tar.gz
packages_apps_Settings-4a806aef49b33f8c823983b9fac120f9b9b837d9.tar.bz2
Settings - Display Rotation: Checkboxes to Switches
Display rotation: Switches to checkboxes According to the guidelines, checkboxes should be used in lists Checkboxes match better than switches in this cas Change-Id: I631c0ef65985d336e1a0790b6bb07ef7524ff6b2 Signed-off-by: STELIX <ssspinni@gmail.com>
Diffstat (limited to 'src/com/android/settings/cyanogenmod')
-rw-r--r--src/com/android/settings/cyanogenmod/DisplayRotation.java17
1 files changed, 9 insertions, 8 deletions
diff --git a/src/com/android/settings/cyanogenmod/DisplayRotation.java b/src/com/android/settings/cyanogenmod/DisplayRotation.java
index 13cb21f..67fa571 100644
--- a/src/com/android/settings/cyanogenmod/DisplayRotation.java
+++ b/src/com/android/settings/cyanogenmod/DisplayRotation.java
@@ -23,6 +23,7 @@ import android.preference.CheckBoxPreference;
import android.preference.Preference;
import android.preference.Preference.OnPreferenceChangeListener;
import android.preference.PreferenceScreen;
+import android.preference.SwitchPreference;
import android.provider.Settings;
import com.android.internal.view.RotationPolicy;
@@ -41,7 +42,7 @@ public class DisplayRotation extends SettingsPreferenceFragment {
private static final String ROTATION_180_PREF = "display_rotation_180";
private static final String ROTATION_270_PREF = "display_rotation_270";
- private CheckBoxPreference mAccelerometer;
+ private SwitchPreference mAccelerometer;
private CheckBoxPreference mRotation0Pref;
private CheckBoxPreference mRotation90Pref;
private CheckBoxPreference mRotation180Pref;
@@ -55,7 +56,7 @@ public class DisplayRotation extends SettingsPreferenceFragment {
private ContentObserver mAccelerometerRotationObserver = new ContentObserver(new Handler()) {
@Override
public void onChange(boolean selfChange) {
- updateAccelerometerRotationCheckbox();
+ updateAccelerometerRotationSwitch();
}
};
@@ -67,7 +68,7 @@ public class DisplayRotation extends SettingsPreferenceFragment {
PreferenceScreen prefSet = getPreferenceScreen();
- mAccelerometer = (CheckBoxPreference) findPreference(KEY_ACCELEROMETER);
+ mAccelerometer = (SwitchPreference) findPreference(KEY_ACCELEROMETER);
mAccelerometer.setPersistent(false);
mRotation0Pref = (CheckBoxPreference) prefSet.findPreference(ROTATION_0_PREF);
@@ -89,7 +90,7 @@ public class DisplayRotation extends SettingsPreferenceFragment {
// com.android.internal.R.bool.config_hasRotationLockSwitch);
if (hasRotationLock) {
- // Disable accelerometer checkbox, but leave others enabled
+ // Disable accelerometer switch, but leave others enabled
mAccelerometer.setEnabled(false);
mRotation0Pref.setDependency(null);
mRotation90Pref.setDependency(null);
@@ -97,8 +98,8 @@ public class DisplayRotation extends SettingsPreferenceFragment {
mRotation270Pref.setDependency(null);
}
- final CheckBoxPreference lockScreenRotation =
- (CheckBoxPreference) findPreference(KEY_LOCKSCREEN_ROTATION);
+ final SwitchPreference lockScreenRotation =
+ (SwitchPreference) findPreference(KEY_LOCKSCREEN_ROTATION);
boolean canRotateLockscreen = getResources().getBoolean(
com.android.internal.R.bool.config_enableLockScreenRotation);
@@ -130,10 +131,10 @@ public class DisplayRotation extends SettingsPreferenceFragment {
}
private void updateState() {
- updateAccelerometerRotationCheckbox();
+ updateAccelerometerRotationSwitch();
}
- private void updateAccelerometerRotationCheckbox() {
+ private void updateAccelerometerRotationSwitch() {
mAccelerometer.setChecked(!RotationPolicy.isRotationLocked(getActivity()));
}