summaryrefslogtreecommitdiffstats
path: root/src/com/android/settings/sim
diff options
context:
space:
mode:
authorDiogo Ferreira <defer@cyngn.com>2016-02-09 11:54:59 +0000
committerGerrit Code Review <gerrit@cyanogenmod.org>2016-02-09 11:46:19 -0800
commitd436b02a4b8748c75ce69bb2737868e0d582bb78 (patch)
treecf00bf230408b2753c58bab6cf818b66515b6629 /src/com/android/settings/sim
parentd24320c102a754c3604f6852a796d1b829a9444a (diff)
downloadpackages_apps_Settings-d436b02a4b8748c75ce69bb2737868e0d582bb78.zip
packages_apps_Settings-d436b02a4b8748c75ce69bb2737868e0d582bb78.tar.gz
packages_apps_Settings-d436b02a4b8748c75ce69bb2737868e0d582bb78.tar.bz2
SimDialogActivity: Check whether there is no default sub
On an out-of-the-box device, no data subscription will be selected by default. If a single SIM is added, it will become the default data subscription but if two sims are added at the same time there will be no default. In this case, this dialog will crash because it's trying to get the subscription id from a null default. This patch short-circuits the clause to always update if there is no default. Change-Id: Icd4dffaf918d43d85f807cd6a14f93abb118eca4 Ticket: CYNGNOS-1940
Diffstat (limited to 'src/com/android/settings/sim')
-rw-r--r--src/com/android/settings/sim/SimDialogActivity.java3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/com/android/settings/sim/SimDialogActivity.java b/src/com/android/settings/sim/SimDialogActivity.java
index 63124d7..2c073e6 100644
--- a/src/com/android/settings/sim/SimDialogActivity.java
+++ b/src/com/android/settings/sim/SimDialogActivity.java
@@ -178,7 +178,8 @@ public class SimDialogActivity extends Activity {
sir = subInfoList.get(value);
SubscriptionInfo defaultSub = subscriptionManager
.getDefaultDataSubscriptionInfo();
- if (defaultSub.getSubscriptionId() != sir.getSubscriptionId()) {
+ if (defaultSub == null || defaultSub.getSubscriptionId()
+ != sir.getSubscriptionId()) {
setDefaultDataSubId(context, sir.getSubscriptionId());
}
break;