Settings: improve job upload service

We should be removing the job even if the job failed.

Change-Id: I7468af9a972fd88c5ed2a93ad5781637407e3a85
Signed-off-by: Roman Birg <roman@cyngn.com>

1 files changed, 8 insertions, 9 deletions

diff --git a/src/com/android/settings/cmstats/StatsUploadJobService.java b/src/com/android/settings/cmstats/StatsUploadJobService.java
index 77b26e6..580a20f 100644
--- a/src/com/android/settings/cmstats/StatsUploadJobService.java
+++ b/src/com/android/settings/cmstats/StatsUploadJobService.java
@@ -88,7 +88,7 @@ public class StatsUploadJobService extends JobService {
         return false;
     }
 
-    private class StatsUploadTask extends AsyncTask<Void, Void, Void> {
+    private class StatsUploadTask extends AsyncTask<Void, Void, Boolean> {
 
         private JobParameters mJobParams;
 
@@ -97,7 +97,7 @@ public class StatsUploadJobService extends JobService {
         }
 
         @Override
-        protected Void doInBackground(Void... params) {
+        protected Boolean doInBackground(Void... params) {
 
             PersistableBundle extras = mJobParams.getExtras();
 
@@ -144,17 +144,16 @@ public class StatsUploadJobService extends JobService {
                         break;
                 }
             }
-
-            if (success) {
-                // we hit the server, succeed either which way.
-                mCurrentJobs.remove(mJobParams);
-            }
-
             if (DEBUG)
                 Log.d(TAG, "job id " + mJobParams.getJobId() + ", has finished with success="
                         + success);
+            return success;
+        }
+
+        @Override
+        protected void onPostExecute(Boolean success) {
+            mCurrentJobs.remove(mJobParams);
             jobFinished(mJobParams, !success);
-            return null;
         }
     }