summaryrefslogtreecommitdiffstats
path: root/src/com/android/browser/Bookmarks.java
diff options
context:
space:
mode:
authorLeon Scroggins III <scroggo@google.com>2010-09-13 14:44:16 -0400
committerLeon Scroggins <scroggo@google.com>2010-09-22 13:21:58 -0400
commit052ce667ce77c4fb3208c0b0dacba7be79c072d9 (patch)
tree1b0dfda1366503a25c3275f3c678886c457eab21 /src/com/android/browser/Bookmarks.java
parent70c77698ce1692e75c8f13aa7670a756da35a6ca (diff)
downloadpackages_apps_browser-052ce667ce77c4fb3208c0b0dacba7be79c072d9.zip
packages_apps_browser-052ce667ce77c4fb3208c0b0dacba7be79c072d9.tar.gz
packages_apps_browser-052ce667ce77c4fb3208c0b0dacba7be79c072d9.tar.bz2
Beginning work on adding bookmarks with folders.
Bug: 2953515 Provides the basic functionality for the AddBookmark page, allowing the user to save the bookmark in a folder of his/her choosing. Change-Id: I170599b723069aaee661dae3fc1a0fb915793906
Diffstat (limited to 'src/com/android/browser/Bookmarks.java')
-rw-r--r--src/com/android/browser/Bookmarks.java8
1 files changed, 3 insertions, 5 deletions
diff --git a/src/com/android/browser/Bookmarks.java b/src/com/android/browser/Bookmarks.java
index 0bccbed..383ae7f 100644
--- a/src/com/android/browser/Bookmarks.java
+++ b/src/com/android/browser/Bookmarks.java
@@ -57,19 +57,18 @@ import java.io.ByteArrayOutputStream;
* @param context Context of the calling Activity. This is used to make
* Toast confirming that the bookmark has been added. If the
* caller provides null, the Toast will not be shown.
- * @param cr The ContentResolver being used to add the bookmark to the db.
* @param url URL of the website to be bookmarked.
* @param name Provided name for the bookmark.
* @param thumbnail A thumbnail for the bookmark.
* @param retainIcon Whether to retain the page's icon in the icon database.
* This will usually be <code>true</code> except when bookmarks are
* added by a settings restore agent.
+ * @param parent ID of the parent folder.
*/
/* package */ static void addBookmark(Context context, boolean showToast, String url,
- String name, Bitmap thumbnail, boolean retainIcon) {
+ String name, Bitmap thumbnail, boolean retainIcon, long parent) {
// Want to append to the beginning of the list
ContentValues values = new ContentValues();
- Cursor cursor = null;
try {
SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(context);
String accountType = prefs.getString(BrowserBookmarksPage.PREF_ACCOUNT_TYPE, null);
@@ -81,11 +80,10 @@ import java.io.ByteArrayOutputStream;
values.put(BrowserContract.Bookmarks.IS_FOLDER, 0);
values.put(BrowserContract.Bookmarks.THUMBNAIL,
bitmapToBytes(thumbnail));
+ values.put(BrowserContract.Bookmarks.PARENT, parent);
context.getContentResolver().insert(BrowserContract.Bookmarks.CONTENT_URI, values);
} catch (IllegalStateException e) {
Log.e(LOGTAG, "addBookmark", e);
- } finally {
- if (cursor != null) cursor.close();
}
if (retainIcon) {
WebIconDatabase.getInstance().retainIconForPageUrl(url);