summaryrefslogtreecommitdiffstats
path: root/src/com/android/browser/provider
diff options
context:
space:
mode:
authorKristian Monsen <kristianm@google.com>2011-07-28 17:12:25 +0100
committerKristian Monsen <kristianm@google.com>2011-07-28 17:56:22 +0100
commitfc49252cdafd9c358b9b15fb0dcb973f09c8eb07 (patch)
tree7d0485973ac637501546c440af0b01f485073e7a /src/com/android/browser/provider
parent56e7068864733e18c666f689c5667d49dcc7b241 (diff)
downloadpackages_apps_browser-fc49252cdafd9c358b9b15fb0dcb973f09c8eb07.zip
packages_apps_browser-fc49252cdafd9c358b9b15fb0dcb973f09c8eb07.tar.gz
packages_apps_browser-fc49252cdafd9c358b9b15fb0dcb973f09c8eb07.tar.bz2
Fix for bug 5090755 StrictMode violation BrowserProvider2 - Cursor not closed
Closing all cursors in the file that were not closed. Change-Id: I0dd3f4d438d1cb8390ac297322ee38d0afd50fea
Diffstat (limited to 'src/com/android/browser/provider')
-rw-r--r--src/com/android/browser/provider/BrowserProvider2.java11
1 files changed, 8 insertions, 3 deletions
diff --git a/src/com/android/browser/provider/BrowserProvider2.java b/src/com/android/browser/provider/BrowserProvider2.java
index fe7a31b..1328040 100644
--- a/src/com/android/browser/provider/BrowserProvider2.java
+++ b/src/com/android/browser/provider/BrowserProvider2.java
@@ -1227,6 +1227,7 @@ public class BrowserProvider2 extends SQLiteContentProvider {
new String[] { Long.toString(id) });
}
}
+ c.close();
break;
}
case THUMBNAILS_ID: {
@@ -1259,8 +1260,12 @@ public class BrowserProvider2 extends SQLiteContentProvider {
" AND account_type = ? AND account_name = ?",
new String[] { ChromeSyncColumns.FOLDER_NAME_BOOKMARKS_BAR,
accountType, accountName }, null, null, null);
- if (c.moveToFirst()) {
- return c.getLong(0);
+ try {
+ if (c.moveToFirst()) {
+ return c.getLong(0);
+ }
+ } finally {
+ c.close();
}
}
return FIXED_ID_ROOT;
@@ -1737,8 +1742,8 @@ public class BrowserProvider2 extends SQLiteContentProvider {
if (c.moveToFirst()) {
parentAccountName = c.getString(0);
parentAccountType = c.getString(1);
- c.close();
}
+ c.close();
} else if (values.containsKey(Bookmarks.ACCOUNT_NAME)
|| values.containsKey(Bookmarks.ACCOUNT_TYPE)) {
// TODO: Implement if needed (no one needs this yet)