summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorNils Holmström <nils.holmstrom@sonymobile.com>2012-04-26 18:46:23 +0200
committerKenneth Andersson <kenneth.andersson@sonymobile.com>2012-08-14 10:49:12 +0200
commit4db7e933f4c26e28f82dc912863f7d02d8fb94ab (patch)
tree01162c2508799eb29c14afbeaf792522e7486fb2 /src
parent39e7dfee746d73670eea435024a80ae9dbedf176 (diff)
downloadpackages_apps_browser-4db7e933f4c26e28f82dc912863f7d02d8fb94ab.zip
packages_apps_browser-4db7e933f4c26e28f82dc912863f7d02d8fb94ab.tar.gz
packages_apps_browser-4db7e933f4c26e28f82dc912863f7d02d8fb94ab.tar.bz2
NPE in WallpaperHandler
In WallpaperHandler, BitmapFactory.decodeStream() is used to create a Bitmap that is then set by WallpaperManager as a wallpaper. This method has null as return value when something fails as decoding, resulting in a nullpointer exception in WallpaperManager. Adding nullcheck on the Bitmap before setting it as wallpaper to avoid the NPE. Change-Id: Ib1a0f9331898162b21094c3ebe80bc21d66f8bd7
Diffstat (limited to 'src')
-rw-r--r--src/com/android/browser/WallpaperHandler.java7
1 files changed, 6 insertions, 1 deletions
diff --git a/src/com/android/browser/WallpaperHandler.java b/src/com/android/browser/WallpaperHandler.java
index b76861c..0c60664 100644
--- a/src/com/android/browser/WallpaperHandler.java
+++ b/src/com/android/browser/WallpaperHandler.java
@@ -130,7 +130,12 @@ public class WallpaperHandler extends Thread
}
Bitmap scaledWallpaper = BitmapFactory.decodeStream(inputstream,
null, options);
- wm.setBitmap(scaledWallpaper);
+ if (scaledWallpaper != null) {
+ wm.setBitmap(scaledWallpaper);
+ } else {
+ Log.e(LOGTAG, "Unable to set new wallpaper, " +
+ "decodeStream returned null.");
+ }
}
} catch (IOException e) {
Log.e(LOGTAG, "Unable to set new wallpaper");