Fix issue #5320747: Disabling an app that is an active device administrator...

...can lead to an unsecure device

Now you can't disable device admins.

Or clear their data.

Or force stop them.

Or uninstall them (though the package manager also prevents uninstalling, might
as well disable this button along with everything else).

Change-Id: I69eefc2342e6f932908e9f5b87d3a601752810a4

1 files changed, 21 insertions, 1 deletions

diff --git a/src/com/android/settings/fuelgauge/PowerUsageDetail.java b/src/com/android/settings/fuelgauge/PowerUsageDetail.java
index e6552ce..79cbac6 100644
--- a/src/com/android/settings/fuelgauge/PowerUsageDetail.java
+++ b/src/com/android/settings/fuelgauge/PowerUsageDetail.java
@@ -20,6 +20,7 @@ import android.app.Activity;
 import android.app.ActivityManager;
 import android.app.ApplicationErrorReport;
 import android.app.Fragment;
+import android.app.admin.DevicePolicyManager;
 import android.content.BroadcastReceiver;
 import android.content.ComponentName;
 import android.content.Context;
@@ -102,7 +103,8 @@ public class PowerUsageDetail extends Fragment implements Button.OnClickListener
     public static final String EXTRA_NO_COVERAGE = "noCoverage";
     public static final String EXTRA_ICON_ID = "iconId"; // Int
 
-    private static final boolean DEBUG = true;
+    private PackageManager mPm;
+    private DevicePolicyManager mDpm;
     private String mTitle;
     private int mUsageSince;
     private int[] mTypes;
@@ -131,6 +133,8 @@ public class PowerUsageDetail extends Fragment implements Button.OnClickListener
     @Override
     public void onCreate(Bundle icicle) {
         super.onCreate(icicle);
+        mPm = getActivity().getPackageManager();
+        mDpm = (DevicePolicyManager)getActivity().getSystemService(Context.DEVICE_POLICY_SERVICE);
     }
 
     @Override
@@ -429,6 +433,22 @@ public class PowerUsageDetail extends Fragment implements Button.OnClickListener
             mForceStopButton.setEnabled(false);
             return;
         }
+        for (int i = 0; i < mPackages.length; i++) {
+            if (mDpm.packageHasActiveAdmins(mPackages[i])) {
+                mForceStopButton.setEnabled(false);
+                return;
+            }
+        }
+        for (int i = 0; i < mPackages.length; i++) {
+            try {
+                ApplicationInfo info = mPm.getApplicationInfo(mPackages[i], 0);
+                if ((info.flags&ApplicationInfo.FLAG_STOPPED) == 0) {
+                    mForceStopButton.setEnabled(true);
+                    break;
+                }
+            } catch (PackageManager.NameNotFoundException e) {
+            }
+        }
         Intent intent = new Intent(Intent.ACTION_QUERY_PACKAGE_RESTART,
                 Uri.fromParts("package", mPackages[0], null));
         intent.putExtra(Intent.EXTRA_PACKAGES, mPackages);