synchronize photo storage creation for race conditions.

Several exceptions were reported regarding "Unable to create photo storage
directory /data/user/0/com.android.providers.contacts/files/photos".
It might caused by the fact that File.makeDirs() is not thread safe.
So make it syncrhonized to resolve this issue.

Bug:17505392
Bug:17449819
Change-Id: I494204424c024c2166340af609423a669e741761

1 files changed, 8 insertions, 4 deletions

diff --git a/src/com/android/providers/contacts/PhotoStore.java b/src/com/android/providers/contacts/PhotoStore.java
index e7be48c..79042c4 100644
--- a/src/com/android/providers/contacts/PhotoStore.java
+++ b/src/com/android/providers/contacts/PhotoStore.java
@@ -39,6 +39,8 @@ import java.util.Set;
  */
 public class PhotoStore {
 
+    private static final Object MKDIRS_LOCK = new Object();
+
     private final String TAG = PhotoStore.class.getSimpleName();
 
     // Directory name under the root directory for photo storage.
@@ -66,10 +68,12 @@ public class PhotoStore {
      */
     public PhotoStore(File rootDirectory, ContactsDatabaseHelper databaseHelper) {
         mStorePath = new File(rootDirectory, DIRECTORY);
-        if (!mStorePath.exists()) {
-            if(!mStorePath.mkdirs()) {
-                throw new RuntimeException("Unable to create photo storage directory "
-                        + mStorePath.getPath());
+        synchronized (MKDIRS_LOCK) {
+            if (!mStorePath.exists()) {
+                if (!mStorePath.mkdirs()) {
+                    throw new RuntimeException("Unable to create photo storage directory "
+                            + mStorePath.getPath());
+                }
             }
         }
         mDatabaseHelper = databaseHelper;