ADT GLE unit tests.

There isn't as much as would want to here.
I need to refactor the RulesEngine to make it more testable,
the major block is that it uses the static AdtPlugin to find
the groovy files path and that doesn't exist in the UT.

Change-Id: I96c0821252d5b777665ed68153fde63d140d0ee5

3 files changed, 85 insertions, 7 deletions

diff --git a/eclipse/plugins/com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/internal/editors/layout/gre/RulesEngine.java b/eclipse/plugins/com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/internal/editors/layout/gre/RulesEngine.java
index 12ac0b3..2fcff2b 100755
--- a/eclipse/plugins/com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/internal/editors/layout/gre/RulesEngine.java
+++ b/eclipse/plugins/com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/internal/editors/layout/gre/RulesEngine.java
@@ -18,6 +18,8 @@ package com.android.ide.eclipse.adt.internal.editors.layout.gre;
 
 import com.android.ide.eclipse.adt.AdtPlugin;
 import com.android.ide.eclipse.adt.AndroidConstants;
+import com.android.ide.eclipse.adt.annotations.VisibleForTesting;
+import com.android.ide.eclipse.adt.annotations.VisibleForTesting.Visibility;
 import com.android.ide.eclipse.adt.editors.layout.gscripts.DropFeedback;
 import com.android.ide.eclipse.adt.editors.layout.gscripts.IClientRulesEngine;
 import com.android.ide.eclipse.adt.editors.layout.gscripts.IDragElement;
@@ -81,7 +83,8 @@ public class RulesEngine {
      * The project folder where the scripts are located.
      * This is for both our unique ADT project folder and the user projects folders.
      */
-    private static final String FD_GSCRIPTS = "gscripts";                       //$NON-NLS-1$
+    @VisibleForTesting(visibility=Visibility.PRIVATE)
+    public static final String FD_GSCRIPTS = "gscripts";                       //$NON-NLS-1$
     /**
      * The extension we expect for the groovy scripts.
      */
@@ -98,6 +101,13 @@ public class RulesEngine {
     private ProjectFolderListener mProjectFolderListener;
 
 
+    /**
+     * Creates a new {@link RulesEngine} associated with the selected project.
+     * <p/>
+     * The rules engine will look in the projects "/gscripts" folder for custom view rules.
+     *
+     * @param project A non-null open project.
+     */
     public RulesEngine(IProject project) {
         mProject = project;
         ClassLoader cl = getClass().getClassLoader();
diff --git a/eclipse/plugins/com.android.ide.eclipse.tests/unittests/com/android/ide/eclipse/adt/internal/editors/layout/gre/NodeFactoryTest.java b/eclipse/plugins/com.android.ide.eclipse.tests/unittests/com/android/ide/eclipse/adt/internal/editors/layout/gre/NodeFactoryTest.java
index c5dd8a4..64b6a63 100755
--- a/eclipse/plugins/com.android.ide.eclipse.tests/unittests/com/android/ide/eclipse/adt/internal/editors/layout/gre/NodeFactoryTest.java
+++ b/eclipse/plugins/com.android.ide.eclipse.tests/unittests/com/android/ide/eclipse/adt/internal/editors/layout/gre/NodeFactoryTest.java
@@ -45,7 +45,7 @@ public class NodeFactoryTest extends TestCase {
     }
 
     public final void testCreateCanvasViewInfo() {
-        ViewElementDescriptor ved = new ViewElementDescriptor("xml", "MyJavaClass");
+        ViewElementDescriptor ved = new ViewElementDescriptor("xml", "com.example.MyJavaClass");
         UiViewElementNode uiv = new UiViewElementNode(ved);
         MockLayoutViewInfo lvi = new MockLayoutViewInfo(uiv, "name", 10, 12, 110, 120);
         CanvasViewInfo cvi = new CanvasViewInfo(lvi);
@@ -61,14 +61,14 @@ public class NodeFactoryTest extends TestCase {
         INode inode = proxy;
         assertEquals(new Rect(10, 12, 110-10-1, 120-12-1), inode.getBounds());
         assertTrue(Arrays.equals(new INode[0], inode.getChildren()));
-        assertEquals("MyJavaClass", inode.getFqcn());
+        assertEquals("com.example.MyJavaClass", inode.getFqcn());
         assertNull(inode.getParent());
         assertSame(inode, inode.getRoot());
 
     }
 
     public final void testCreateUiViewElementNode() {
-        ViewElementDescriptor ved = new ViewElementDescriptor("xml", "MyJavaClass");
+        ViewElementDescriptor ved = new ViewElementDescriptor("xml", "com.example.MyJavaClass");
         UiViewElementNode uiv = new UiViewElementNode(ved);
 
         // Create a NodeProxy.
@@ -86,13 +86,13 @@ public class NodeFactoryTest extends TestCase {
         assertFalse(inode.getBounds().isValid());
         // All the other properties should be set correctly.
         assertTrue(Arrays.equals(new INode[0], inode.getChildren()));
-        assertEquals("MyJavaClass", inode.getFqcn());
+        assertEquals("com.example.MyJavaClass", inode.getFqcn());
         assertNull(inode.getParent());
         assertSame(inode, inode.getRoot());
     }
 
     public final void testCreateDup() {
-        ViewElementDescriptor ved = new ViewElementDescriptor("xml", "MyJavaClass");
+        ViewElementDescriptor ved = new ViewElementDescriptor("xml", "com.example.MyJavaClass");
         UiViewElementNode uiv = new UiViewElementNode(ved);
         MockLayoutViewInfo lvi = new MockLayoutViewInfo(uiv, "name", 10, 12, 110, 120);
         CanvasViewInfo cvi = new CanvasViewInfo(lvi);
@@ -104,7 +104,7 @@ public class NodeFactoryTest extends TestCase {
     }
 
     public final void testClear() {
-        ViewElementDescriptor ved = new ViewElementDescriptor("xml", "MyJavaClass");
+        ViewElementDescriptor ved = new ViewElementDescriptor("xml", "com.example.MyJavaClass");
         UiViewElementNode uiv = new UiViewElementNode(ved);
         MockLayoutViewInfo lvi = new MockLayoutViewInfo(uiv, "name", 10, 12, 110, 120);
         CanvasViewInfo cvi = new CanvasViewInfo(lvi);
diff --git a/eclipse/plugins/com.android.ide.eclipse.tests/unittests/com/android/ide/eclipse/adt/internal/editors/layout/gre/RulesEngineTest.java b/eclipse/plugins/com.android.ide.eclipse.tests/unittests/com/android/ide/eclipse/adt/internal/editors/layout/gre/RulesEngineTest.java
new file mode 100755
index 0000000..5ba0092
--- /dev/null
+++ b/eclipse/plugins/com.android.ide.eclipse.tests/unittests/com/android/ide/eclipse/adt/internal/editors/layout/gre/RulesEngineTest.java
@@ -0,0 +1,68 @@
+/*
+ * Copyright (C) 2010 The Android Open Source Project
+ *
+ * Licensed under the Eclipse Public License, Version 1.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.eclipse.org/org/documents/epl-v10.php
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.android.ide.eclipse.adt.internal.editors.layout.gre;
+
+import com.android.ide.eclipse.adt.internal.editors.layout.descriptors.ViewElementDescriptor;
+import com.android.ide.eclipse.adt.internal.editors.layout.uimodel.UiViewElementNode;
+import com.android.sdklib.SdkConstants;
+
+import org.easymock.EasyMock;
+import org.eclipse.core.resources.IProject;
+
+import junit.framework.TestCase;
+
+public class RulesEngineTest extends TestCase {
+
+    @Override
+    protected void setUp() throws Exception {
+        super.setUp();
+    }
+
+    @Override
+    protected void tearDown() throws Exception {
+        super.tearDown();
+    }
+
+    public void testCreate() {
+        // Creating a RulesEngine from a given project should ask for the location
+        // of the projects' /gscripts folder.
+        IProject projectMock = EasyMock.createMock(IProject.class);
+        EasyMock.expect(projectMock.findMember(RulesEngine.FD_GSCRIPTS)).andReturn(null);
+        EasyMock.replay(projectMock);
+
+        RulesEngine r = new RulesEngine(projectMock);
+        assertNotNull(r);
+
+        EasyMock.verify(projectMock);
+    }
+
+    public void testCallGetDisplayName() {
+        IProject projectMock = EasyMock.createMock(IProject.class);
+        EasyMock.expect(projectMock.findMember(RulesEngine.FD_GSCRIPTS)).andReturn(null);
+        EasyMock.expect(projectMock.getName()).andReturn("unit-test");
+        EasyMock.replay(projectMock);
+
+        RulesEngine r = new RulesEngine(projectMock);
+
+        ViewElementDescriptor ved = new ViewElementDescriptor("view", SdkConstants.CLASS_VIEW);
+        UiViewElementNode uiv = new UiViewElementNode(ved);
+
+        // TODO: this test is not ready. We need a way to override
+        // String result = r.callGetDisplayName(uiv);
+        // assertEquals("com.example.MyJavaClass", result);
+    }
+}