diff options
| author | Siva Velusamy <vsiva@google.com> | 2013-01-10 10:46:05 -0800 |
|---|---|---|
| committer | Siva Velusamy <vsiva@google.com> | 2013-01-13 15:17:39 -0800 |
| commit | 736d88eb9fac11610390958b3d4000d6deaa1711 (patch) | |
| tree | f817b56feb6353b80443688315e578f68da67d0f /eclipse/plugins | |
| parent | 5b30d8114124620147d411c4e74bac426b7d34d4 (diff) | |
| download | sdk-736d88eb9fac11610390958b3d4000d6deaa1711.zip sdk-736d88eb9fac11610390958b3d4000d6deaa1711.tar.gz sdk-736d88eb9fac11610390958b3d4000d6deaa1711.tar.bz2 | |
hv: Refactor to interact with the device via IHvDevice
Hierarchy Viewer currently interacts with a View Server that
is present on the device. This is available only on eng devices
due to security restrictions on the View Server.
Rather than use this custom view server, we ought to use DDM
for communication with the device. Such a scheme has a number of
benefits apart from security.
This CL is primarily just a refactoring of the existing host
side code. The main objective is to hide the communication to
the device behind a IHvDevice interface. The ViewServerDevice
implementation of this interface allows communicating with
existing devices that use the ViewServer implementation on
the device. A subsequent CL will provide a new implementation
of this interface that communicates via DDM.
Change-Id: I7d63e5a59c6ec9c96dbd07af9dc03f93779fd2ec
Diffstat (limited to 'eclipse/plugins')
| -rw-r--r-- | eclipse/plugins/com.android.ide.eclipse.hierarchyviewer/src/com/android/ide/eclipse/hierarchyviewer/HierarchyViewerPluginDirector.java | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/eclipse/plugins/com.android.ide.eclipse.hierarchyviewer/src/com/android/ide/eclipse/hierarchyviewer/HierarchyViewerPluginDirector.java b/eclipse/plugins/com.android.ide.eclipse.hierarchyviewer/src/com/android/ide/eclipse/hierarchyviewer/HierarchyViewerPluginDirector.java index e950c60..597f7a4 100644 --- a/eclipse/plugins/com.android.ide.eclipse.hierarchyviewer/src/com/android/ide/eclipse/hierarchyviewer/HierarchyViewerPluginDirector.java +++ b/eclipse/plugins/com.android.ide.eclipse.hierarchyviewer/src/com/android/ide/eclipse/hierarchyviewer/HierarchyViewerPluginDirector.java @@ -16,9 +16,9 @@ package com.android.ide.eclipse.hierarchyviewer; -import com.android.ddmlib.IDevice; import com.android.hierarchyviewerlib.HierarchyViewerDirector; -import com.android.hierarchyviewerlib.device.Window; +import com.android.hierarchyviewerlib.device.IHvDevice; +import com.android.hierarchyviewerlib.models.Window; import com.android.ide.eclipse.hierarchyviewer.views.PixelPerfectTreeView; import com.android.ide.eclipse.hierarchyviewer.views.PropertyView; @@ -97,7 +97,7 @@ public class HierarchyViewerPluginDirector extends HierarchyViewerDirector { } @Override - public void loadPixelPerfectData(IDevice device) { + public void loadPixelPerfectData(IHvDevice device) { super.loadPixelPerfectData(device); // The windows tab hides the tree tab, so let's bring the tree tab |