aboutsummaryrefslogtreecommitdiffstats
path: root/manifmerger
diff options
context:
space:
mode:
authorTor Norbye <tnorbye@google.com>2012-10-23 14:59:04 -0700
committerTor Norbye <tnorbye@google.com>2012-10-25 15:22:21 -0700
commitc7df8d23830cc48f5741d44e2a978fc9ca52b003 (patch)
tree35e364ecc8978613267b1fcb0a08f7f7ac8e805e /manifmerger
parent152af2d57d5e2a6874e14fa1557566c6df7f9dad (diff)
downloadsdk-c7df8d23830cc48f5741d44e2a978fc9ca52b003.zip
sdk-c7df8d23830cc48f5741d44e2a978fc9ca52b003.tar.gz
sdk-c7df8d23830cc48f5741d44e2a978fc9ca52b003.tar.bz2
Close file streams used by parsers (and add guava to sdkcommon)
Plus some nullness annotations. Change-Id: Ia75c6ffa5d6296c991fc86fec050f285b9143429
Diffstat (limited to 'manifmerger')
-rwxr-xr-xmanifmerger/src/com/android/manifmerger/MergerXmlUtils.java5
1 files changed, 4 insertions, 1 deletions
diff --git a/manifmerger/src/com/android/manifmerger/MergerXmlUtils.java b/manifmerger/src/com/android/manifmerger/MergerXmlUtils.java
index 4381479..bb60464 100755
--- a/manifmerger/src/com/android/manifmerger/MergerXmlUtils.java
+++ b/manifmerger/src/com/android/manifmerger/MergerXmlUtils.java
@@ -32,9 +32,11 @@ import org.xml.sax.ErrorHandler;
import org.xml.sax.InputSource;
import org.xml.sax.SAXParseException;
+import java.io.BufferedReader;
import java.io.File;
import java.io.FileNotFoundException;
import java.io.FileReader;
+import java.io.Reader;
import java.io.StringReader;
import java.io.StringWriter;
import java.util.ArrayList;
@@ -80,7 +82,8 @@ class MergerXmlUtils {
static Document parseDocument(@NonNull final File xmlFile, @NonNull final IMergerLog log) {
try {
DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
- InputSource is = new InputSource(new FileReader(xmlFile));
+ Reader reader = new BufferedReader(new FileReader(xmlFile));
+ InputSource is = new InputSource(reader);
factory.setNamespaceAware(true);
factory.setValidating(false);
DocumentBuilder builder = factory.newDocumentBuilder();