diff options
Diffstat (limited to 'lint/libs')
| -rw-r--r-- | lint/libs/lint_checks/tests/src/com/android/tools/lint/MainTest.java | 35 | ||||
| -rw-r--r-- | lint/libs/lint_checks/tests/src/com/android/tools/lint/XmlReporterTest.java | 99 |
2 files changed, 134 insertions, 0 deletions
diff --git a/lint/libs/lint_checks/tests/src/com/android/tools/lint/MainTest.java b/lint/libs/lint_checks/tests/src/com/android/tools/lint/MainTest.java index 4e7a029..d015a3d 100644 --- a/lint/libs/lint_checks/tests/src/com/android/tools/lint/MainTest.java +++ b/lint/libs/lint_checks/tests/src/com/android/tools/lint/MainTest.java @@ -260,4 +260,39 @@ public class MainTest extends AbstractCheckTest { super("Unit test"); } } + + public void test_getCleanPath() throws Exception { + assertEquals("foo", Main.getCleanPath(new File("foo"))); + String sep = File.separator; + assertEquals("foo" + sep + "bar", + Main.getCleanPath(new File("foo" + sep + "bar"))); + assertEquals(sep, + Main.getCleanPath(new File(sep))); + assertEquals("foo" + sep + "bar", + Main.getCleanPath(new File("foo" + sep + "." + sep + "bar"))); + assertEquals("bar", + Main.getCleanPath(new File("foo" + sep + ".." + sep + "bar"))); + assertEquals("", + Main.getCleanPath(new File("foo" + sep + ".."))); + assertEquals("foo", + Main.getCleanPath(new File("foo" + sep + "bar" + sep + ".."))); + assertEquals("foo" + sep + ".foo" + sep + "bar", + Main.getCleanPath(new File("foo" + sep + ".foo" + sep + "bar"))); + assertEquals("foo" + sep + "bar", + Main.getCleanPath(new File("foo" + sep + "bar" + sep + "."))); + assertEquals("foo" + sep + "...", + Main.getCleanPath(new File("foo" + sep + "..."))); + assertEquals(".." + sep + "foo", + Main.getCleanPath(new File(".." + sep + "foo"))); + assertEquals(sep + "foo", + Main.getCleanPath(new File(sep + "foo"))); + assertEquals(sep, + Main.getCleanPath(new File(sep + "foo" + sep + ".."))); + assertEquals(sep + "foo", + Main.getCleanPath(new File(sep + "foo" + sep + "bar " + sep + ".."))); + assertEquals(sep + "c:", + Main.getCleanPath(new File(sep + "c:"))); + assertEquals(sep + "c:" + sep + "foo", + Main.getCleanPath(new File(sep + "c:" + sep + "foo"))); + } } diff --git a/lint/libs/lint_checks/tests/src/com/android/tools/lint/XmlReporterTest.java b/lint/libs/lint_checks/tests/src/com/android/tools/lint/XmlReporterTest.java index 95147b4..166f721 100644 --- a/lint/libs/lint_checks/tests/src/com/android/tools/lint/XmlReporterTest.java +++ b/lint/libs/lint_checks/tests/src/com/android/tools/lint/XmlReporterTest.java @@ -133,6 +133,105 @@ public class XmlReporterTest extends AbstractCheckTest { } } + public void testFullPaths() throws Exception { + File file = new File(getTargetDir(), "report"); + try { + Main client = new Main() { + @Override + String getRevision() { + return "unittest"; // Hardcode version to keep unit test output stable + } + }; + client.mFullPath = true; + + file.getParentFile().mkdirs(); + XmlReporter reporter = new XmlReporter(client, file); + Project project = Project.create(client, new File("/foo/bar/Foo"), + new File("/foo/bar/Foo")); + + Warning warning1 = new Warning(ManifestOrderDetector.USES_SDK, + "<uses-sdk> tag should specify a target API level (the highest verified " + + "version; when running on later versions, compatibility behaviors may " + + "be enabled) with android:targetSdkVersion=\"?\"", + Severity.WARNING, project, null); + warning1.line = 6; + warning1.file = new File("/foo/bar/../Foo/AndroidManifest.xml"); + warning1.errorLine = " <uses-sdk android:minSdkVersion=\"8\" />\n ^\n"; + warning1.path = "AndroidManifest.xml"; + warning1.location = Location.create(warning1.file, + new DefaultPosition(6, 4, 198), new DefaultPosition(6, 42, 236)); + + Warning warning2 = new Warning(HardcodedValuesDetector.ISSUE, + "[I18N] Hardcoded string \"Fooo\", should use @string resource", + Severity.WARNING, project, null); + warning2.line = 11; + warning2.file = new File("/foo/bar/Foo/res/layout/main.xml"); + warning2.errorLine = " (java.lang.String) android:text=\"Fooo\" />\n" + + " ~~~~~~~~~~~~~~~~~~~\n"; + warning2.path = "res/layout/main.xml"; + warning2.location = Location.create(warning2.file, + new DefaultPosition(11, 8, 377), new DefaultPosition(11, 27, 396)); + + List<Warning> warnings = new ArrayList<Warning>(); + warnings.add(warning1); + warnings.add(warning2); + + reporter.write(0, 2, warnings); + + String report = Files.toString(file, Charsets.UTF_8); + assertEquals( + "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n" + + "<issues format=\"3\" by=\"lint unittest\">\n" + + "\n" + + " <issue\n" + + " id=\"UsesMinSdkAttributes\"\n" + + " severity=\"Warning\"\n" + + " message=\"<uses-sdk> tag should specify a target API level (the highest verified version; when running on later versions, compatibility behaviors may be enabled) with android:targetSdkVersion="?"\"\n" + + " category=\"Correctness\"\n" + + " priority=\"9\"\n" + + " summary=\"Checks that the minimum SDK and target SDK attributes are defined\"\n" + + " explanation=\"The manifest should contain a `<uses-sdk>` element which defines the minimum minimum API Level required for the application to run, as well as the target version (the highest API level you have tested the version for.)\"\n" + + " url=\"http://developer.android.com/guide/topics/manifest/uses-sdk-element.html\"\n" + + " errorLine1=\" <uses-sdk android:minSdkVersion="8" />\"\n" + + " errorLine2=\" ^\">\n" + + " <location\n" + + " file=\"/foo/Foo/AndroidManifest.xml\"\n" + + " line=\"7\"\n" + + " column=\"5\"/>\n" + + " </issue>\n" + + "\n" + + " <issue\n" + + " id=\"HardcodedText\"\n" + + " severity=\"Warning\"\n" + + " message=\"[I18N] Hardcoded string "Fooo", should use @string resource\"\n" + + " category=\"Internationalization\"\n" + + " priority=\"5\"\n" + + " summary=\"Looks for hardcoded text attributes which should be converted to resource lookup\"\n" + + " explanation=\"Hardcoding text attributes directly in layout files is bad for several reasons:\n" + + "\n" + + "* When creating configuration variations (for example for landscape or portrait)you have to repeat the actual text (and keep it up to date when making changes)\n" + + "\n" + + "* The application cannot be translated to other languages by just adding new translations for existing string resources.\"\n" + + " errorLine1=\" (java.lang.String) android:text="Fooo" />\"\n" + + " errorLine2=\" ~~~~~~~~~~~~~~~~~~~\">\n" + + " <location\n" + + " file=\"/foo/bar/Foo/res/layout/main.xml\"\n" + + " line=\"12\"\n" + + " column=\"9\"/>\n" + + " </issue>\n" + + "\n" + + "</issues>\n", + report); + + // Make sure the XML is valid + Document document = new PositionXmlParser().parse(report); + assertNotNull(document); + assertEquals(2, document.getElementsByTagName("issue").getLength()); + } finally { + file.delete(); + } + } + @Override protected Detector getDetector() { fail("Not used in this test"); |