1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
|
/*
* Copyright (C) 2011 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.android.tools.lint.checks;
import com.android.tools.lint.detector.api.Detector;
@SuppressWarnings("javadoc")
public class IconDetectorTest extends AbstractCheckTest {
@Override
protected Detector getDetector() {
return new IconDetector();
}
public void test() throws Exception {
assertEquals(
"res/drawable-mdpi/sample_icon.gif: Warning: Using the .gif format for bitmaps is discouraged [GifUsage]\n" +
"res/drawable/ic_launcher.png: Warning: The ic_launcher.png icon has identical contents in the following configuration folders: drawable-mdpi, drawable [IconDuplicatesConfig]\n" +
" res/drawable-mdpi/ic_launcher.png: <No location-specific message\n" +
"res/drawable/ic_launcher.png: Warning: Found bitmap drawable res/drawable/ic_launcher.png in densityless folder [IconLocation]\n" +
"res/drawable-hdpi: Warning: Missing the following drawables in drawable-hdpi: sample_icon.gif (found in drawable-mdpi) [IconDensities]\n" +
"res: Warning: Missing density variation folders in res: drawable-xhdpi [IconMissingDensityFolder]\n" +
"0 errors, 5 warnings\n" +
"",
lintProject(
// Use minSDK4 to ensure that we get warnings about missing drawables
"apicheck/minsdk4.xml=>AndroidManifest.xml",
"res/drawable/ic_launcher.png",
"res/drawable/ic_launcher.png=>res/drawable-mdpi/ic_launcher.png",
"res/drawable-mdpi/sample_icon.gif",
// Make a dummy file named .svn to make sure it doesn't get seen as
// an icon name
"res/drawable-mdpi/sample_icon.gif=>res/drawable-hdpi/.svn",
"res/drawable-hdpi/ic_launcher.png"));
}
public void testApi1() throws Exception {
assertEquals(
"No warnings.",
lintProject(
// manifest file which specifies uses sdk = 2
"apicheck/minsdk2.xml=>AndroidManifest.xml",
"res/drawable/ic_launcher.png"));
}
public void test2() throws Exception {
assertEquals(
"res/drawable-hdpi/other.9.png: Warning: The following unrelated icon files have identical contents: appwidget_bg.9.png, other.9.png [IconDuplicates]\n" +
" res/drawable-hdpi/appwidget_bg.9.png: <No location-specific message\n" +
"res/drawable-hdpi/unrelated.png: Warning: The following unrelated icon files have identical contents: ic_launcher.png, unrelated.png [IconDuplicates]\n" +
" res/drawable-hdpi/ic_launcher.png: <No location-specific message\n" +
"res: Warning: Missing density variation folders in res: drawable-mdpi, drawable-xhdpi [IconMissingDensityFolder]\n" +
"0 errors, 3 warnings\n" +
"",
lintProject(
"res/drawable-hdpi/unrelated.png",
"res/drawable-hdpi/appwidget_bg.9.png",
"res/drawable-hdpi/appwidget_bg_focus.9.png",
"res/drawable-hdpi/other.9.png",
"res/drawable-hdpi/ic_launcher.png"
));
}
public void testNoDpi() throws Exception {
assertEquals(
"res/drawable-mdpi/frame.png: Warning: The following images appear in both -nodpi and in a density folder: frame.png [IconNoDpi]\n" +
"res/drawable-xlarge-nodpi-v11/frame.png: Warning: The frame.png icon has identical contents in the following configuration folders: drawable-mdpi, drawable-nodpi, drawable-xlarge-nodpi-v11 [IconDuplicatesConfig]\n" +
" res/drawable-nodpi/frame.png: <No location-specific message\n" +
" res/drawable-mdpi/frame.png: <No location-specific message\n" +
"res: Warning: Missing density variation folders in res: drawable-hdpi, drawable-xhdpi [IconMissingDensityFolder]\n" +
"0 errors, 3 warnings\n" +
"",
lintProject(
"res/drawable-mdpi/frame.png",
"res/drawable-nodpi/frame.png",
"res/drawable-xlarge-nodpi-v11/frame.png"));
}
public void testNoDpi2() throws Exception {
// Having additional icon names in the no-dpi folder should not cause any complaints
assertEquals(
"res/drawable-xhdpi/frame.png: Warning: The image frame.png varies significantly in its density-independent (dip) size across the various density versions: drawable-ldpi/frame.png: 629x387 dp (472x290 px), drawable-mdpi/frame.png: 472x290 dp (472x290 px), drawable-hdpi/frame.png: 315x193 dp (472x290 px), drawable-xhdpi/frame.png: 236x145 dp (472x290 px) [IconDipSize]\n" +
" res/drawable-hdpi/frame.png: <No location-specific message\n" +
" res/drawable-mdpi/frame.png: <No location-specific message\n" +
" res/drawable-ldpi/frame.png: <No location-specific message\n" +
"res/drawable-xhdpi/frame.png: Warning: The following unrelated icon files have identical contents: frame.png, frame.png, frame.png, file1.png, file2.png, frame.png [IconDuplicates]\n" +
" res/drawable-nodpi/file2.png: <No location-specific message\n" +
" res/drawable-nodpi/file1.png: <No location-specific message\n" +
" res/drawable-mdpi/frame.png: <No location-specific message\n" +
" res/drawable-ldpi/frame.png: <No location-specific message\n" +
" res/drawable-hdpi/frame.png: <No location-specific message\n" +
"0 errors, 2 warnings\n" +
"",
lintProject(
"res/drawable-mdpi/frame.png=>res/drawable-mdpi/frame.png",
"res/drawable-mdpi/frame.png=>res/drawable-hdpi/frame.png",
"res/drawable-mdpi/frame.png=>res/drawable-ldpi/frame.png",
"res/drawable-mdpi/frame.png=>res/drawable-xhdpi/frame.png",
"res/drawable-mdpi/frame.png=>res/drawable-nodpi/file1.png",
"res/drawable-mdpi/frame.png=>res/drawable-nodpi/file2.png"));
}
public void testNoDpiMix() throws Exception {
assertEquals(
"res/drawable-mdpi/frame.xml: Warning: The following images appear in both -nodpi and in a density folder: frame.png, frame.xml [IconNoDpi]\n" +
" res/drawable-mdpi/frame.png: <No location-specific message\n" +
"res: Warning: Missing density variation folders in res: drawable-hdpi, drawable-xhdpi [IconMissingDensityFolder]\n" +
"0 errors, 2 warnings\n" +
"",
lintProject(
"res/drawable-mdpi/frame.png",
"res/drawable/states.xml=>res/drawable-nodpi/frame.xml"));
}
public void testMixedFormat() throws Exception {
// Test having a mixture of .xml and .png resources for the same name
// Make sure we don't get:
// drawable-hdpi: Warning: Missing the following drawables in drawable-hdpi: f.png (found in drawable-mdpi)
// drawable-xhdpi: Warning: Missing the following drawables in drawable-xhdpi: f.png (found in drawable-mdpi)
assertEquals(
"No warnings.",
lintProject(
"res/drawable-mdpi/frame.png=>res/drawable-mdpi/f.png",
"res/drawable/states.xml=>res/drawable-hdpi/f.xml",
"res/drawable/states.xml=>res/drawable-xhdpi/f.xml"));
}
}
|
