summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNick Kralevich <nnk@google.com>2014-07-02 22:30:39 -0700
committerNick Kralevich <nnk@google.com>2014-07-02 22:30:39 -0700
commit118d1b393067fbc4fbb26af6815a7a4f131f0148 (patch)
tree04485327253ef10ea99e2c31bda23ec21caaa26d
parent09117c70f1cc0de77c62d6f7f5bee04e3fc7ef83 (diff)
downloadsystem_core-118d1b393067fbc4fbb26af6815a7a4f131f0148.zip
system_core-118d1b393067fbc4fbb26af6815a7a4f131f0148.tar.gz
system_core-118d1b393067fbc4fbb26af6815a7a4f131f0148.tar.bz2
logd_write: set SOCK_CLOEXEC on socket
Socket file descriptors remain open across exec unless SOCK_CLOEXEC is set. Enable this option, to avoid leaking file descriptors. See https://android-review.googlesource.com/53736 for a similar problem with the old logging code. Change-Id: I9e045d2291ae6680044ab86604f3ff2c55b5eaed
-rw-r--r--liblog/logd_write.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/liblog/logd_write.c b/liblog/logd_write.c
index 1da55ab..3171c78 100644
--- a/liblog/logd_write.c
+++ b/liblog/logd_write.c
@@ -107,7 +107,7 @@ static int __write_to_log_initialize()
close(i);
}
- i = socket(PF_UNIX, SOCK_DGRAM, 0);
+ i = socket(PF_UNIX, SOCK_DGRAM | SOCK_CLOEXEC, 0);
if (i < 0) {
ret = -errno;
write_to_log = __write_to_log_null;