diff options
author | Elliott Hughes <enh@google.com> | 2014-05-20 19:18:11 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2014-05-20 19:18:11 +0000 |
commit | 4a343436e01b07c21c043f8a903689f70000ca73 (patch) | |
tree | 4c05e0c1c37884abb31b849bc2a721d389c59d92 | |
parent | 3816305b58b0eeb098f2f989ef03208d1f29f4da (diff) | |
parent | 0bff5bd95268184a34ae69c062584a8d1f4d87fb (diff) | |
download | system_core-4a343436e01b07c21c043f8a903689f70000ca73.zip system_core-4a343436e01b07c21c043f8a903689f70000ca73.tar.gz system_core-4a343436e01b07c21c043f8a903689f70000ca73.tar.bz2 |
Merge "Fix win32 undefined reference to `_socket_network_client_timeout'."
-rw-r--r-- | adb/sysdeps_win32.c | 7 | ||||
-rw-r--r-- | libcutils/Android.mk | 17 | ||||
-rw-r--r-- | libcutils/socket_network_client.c | 10 |
3 files changed, 16 insertions, 18 deletions
diff --git a/adb/sysdeps_win32.c b/adb/sysdeps_win32.c index b0cb048..29f58ec 100644 --- a/adb/sysdeps_win32.c +++ b/adb/sysdeps_win32.c @@ -701,6 +701,13 @@ int socket_network_client(const char *host, int port, int type) } +int socket_network_client_timeout(const char *host, int port, int type, int timeout) +{ + // TODO: implement timeouts for Windows. + return socket_network_client(host, port, type); +} + + int socket_inaddr_any_server(int port, int type) { FH f = _fh_alloc( &_fh_socket_class ); diff --git a/libcutils/Android.mk b/libcutils/Android.mk index 945ebdd..e1d6f49 100644 --- a/libcutils/Android.mk +++ b/libcutils/Android.mk @@ -27,13 +27,6 @@ commonSources := \ hashmap.c \ atomic.c.arm \ native_handle.c \ - socket_inaddr_any_server.c \ - socket_local_client.c \ - socket_local_server.c \ - socket_loopback_client.c \ - socket_loopback_server.c \ - socket_network_client.c \ - sockets.c \ config_utils.c \ cpu_info.c \ load_file.c \ @@ -67,7 +60,15 @@ endif ifneq ($(WINDOWS_HOST_ONLY),1) commonSources += \ fs.c \ - multiuser.c + multiuser.c \ + socket_inaddr_any_server.c \ + socket_local_client.c \ + socket_local_server.c \ + socket_loopback_client.c \ + socket_loopback_server.c \ + socket_network_client.c \ + sockets.c \ + endif diff --git a/libcutils/socket_network_client.c b/libcutils/socket_network_client.c index 8a8474e..4826033 100644 --- a/libcutils/socket_network_client.c +++ b/libcutils/socket_network_client.c @@ -21,13 +21,11 @@ #include <string.h> #include <unistd.h> -#ifndef HAVE_WINSOCK #include <sys/socket.h> #include <sys/select.h> #include <sys/types.h> #include <netinet/in.h> #include <netdb.h> -#endif #include <cutils/sockets.h> @@ -68,13 +66,6 @@ int socket_network_client_timeout(const char *host, int port, int type, int time s = socket(hp->h_addrtype, type, 0); if (s < 0) return -1; -#ifdef HAVE_WINSOCK - if (connect(s, (struct sockaddr *) &addr, sizeof(addr)) < 0) { - close(s); - return -1; - } - return s; -#else if ((flags = fcntl(s, F_GETFL, 0)) < 0) { close(s); return -1; @@ -132,5 +123,4 @@ done: } return s; -#endif } |