summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorColin Cross <ccross@android.com>2013-06-25 00:07:54 +0000
committerGerrit Code Review <noreply-gerritcodereview@google.com>2013-06-25 00:07:54 +0000
commitb6c602859496e212db78435e2b05ec9418189d6c (patch)
tree1e2e4f0d068a17cdd0cd8db98f4bf56eedb29052
parent83ada447aed69dfcd0a88e952eced8db1e4d6584 (diff)
parent2baad525205c944e6ef9005fcb324439f99bcdc8 (diff)
downloadsystem_core-b6c602859496e212db78435e2b05ec9418189d6c.zip
system_core-b6c602859496e212db78435e2b05ec9418189d6c.tar.gz
system_core-b6c602859496e212db78435e2b05ec9418189d6c.tar.bz2
Merge changes Ieb94caab,I762da21e
* changes: init: move initial property area allocation into bionic property_service: make /dev/__properties__ readable
-rwxr-xr-xinit/property_service.c35
1 files changed, 5 insertions, 30 deletions
diff --git a/init/property_service.c b/init/property_service.c
index 86e35f1..70ee4a6 100755
--- a/init/property_service.c
+++ b/init/property_service.c
@@ -110,7 +110,6 @@ struct {
};
typedef struct {
- void *data;
size_t size;
int fd;
} workspace;
@@ -118,38 +117,13 @@ typedef struct {
static int init_workspace(workspace *w, size_t size)
{
void *data;
- int fd;
-
- /* dev is a tmpfs that we can use to carve a shared workspace
- * out of, so let's do that...
- */
- fd = open("/dev/__properties__", O_RDWR | O_CREAT | O_NOFOLLOW, 0600);
+ int fd = open(PROP_FILENAME, O_RDONLY | O_NOFOLLOW);
if (fd < 0)
return -1;
- if (ftruncate(fd, size) < 0)
- goto out;
-
- data = mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
- if(data == MAP_FAILED)
- goto out;
-
- close(fd);
-
- fd = open("/dev/__properties__", O_RDONLY | O_NOFOLLOW);
- if (fd < 0)
- return -1;
-
- unlink("/dev/__properties__");
-
- w->data = data;
w->size = size;
w->fd = fd;
return 0;
-
-out:
- close(fd);
- return -1;
}
static workspace pa_workspace;
@@ -159,12 +133,13 @@ static int init_property_area(void)
if (property_area_inited)
return -1;
- if(init_workspace(&pa_workspace, PA_SIZE))
+ if(__system_property_area_init())
return -1;
- fcntl(pa_workspace.fd, F_SETFD, FD_CLOEXEC);
+ if(init_workspace(&pa_workspace, 0))
+ return -1;
- __system_property_area_init(pa_workspace.data);
+ fcntl(pa_workspace.fd, F_SETFD, FD_CLOEXEC);
property_area_inited = 1;
return 0;